Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters missing from the FAQ. #7470

Open
pierluigilenoci opened this issue Nov 6, 2024 · 5 comments · May be fixed by #7467
Open

Parameters missing from the FAQ. #7470

pierluigilenoci opened this issue Nov 6, 2024 · 5 comments · May be fixed by #7467
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.

Comments

@pierluigilenoci
Copy link
Contributor

Which component are you using?:

cluster-autoscaler

What version of the component are you using?:

Component version: All

What k8s version are you using (kubectl version)?:

Not relevant

What environment is this in?:

Not relevant

What did you expect to happen?:

To have all the Autoscaler parameters documented.

What happened instead?:

At least 2 parameters were missing.

How to reproduce it (as minimally and precisely as possible):

Search for node-deletion-delay-timeout or node-deletion-batcher-interval in the FAQ page.

Anything else we need to know?:

Nope
@pierluigilenoci pierluigilenoci added the kind/bug Categorizes issue or PR as related to a bug. label Nov 6, 2024
@pierluigilenoci pierluigilenoci linked a pull request Nov 6, 2024 that will close this issue
Open
@adrianmoisey
Copy link
Member

/area cluster-autoscaler

@Shubham82
Copy link
Contributor

Shubham82 commented Nov 7, 2024 •
edited
Loading

Hi @pierluigilenoci, there is already PR #7014 opened for adding all the parameters/flags in FAQ.md.
PTAL!

@pierluigilenoci
Copy link
Contributor Author

@Shubham82 Well, let's merge it then. 🚀

@Shubham82
Copy link
Contributor

@Shubham82 Well, let's merge it then. 🚀

Yeah, waiting for other members' opinions on Log flags, I hope it will mere soon.

@pierluigilenoci
Copy link
Contributor Author

@Shubham82 any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/cluster-autoscaler kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(helm): integrate the helm chart pierluigilenoci/autoscaler
4 participants
@adrianmoisey @k8s-ci-robot @pierluigilenoci @Shubham82