-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Helm chart manifests in the e2e tests #366
Comments
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/remove-lifecycle rotten |
/assign Hi @mauriciopoppe , I can help on this issue. But i need some help as I not sure how to go about this |
I updated the description with more info, hope it helps |
Sure, the description looks good to me. Will give this a try when I have some time on hand later on. Will ping you once I am done with the PR |
So our e2e tests create a test cluster and install LVP using go code
sig-storage-local-static-provisioner/test/e2e/e2e_test.go
Line 296 in 8335a2a
sig-storage-local-static-provisioner/test/e2e/e2e_test.go
Line 311 in 8335a2a
And if you look at the implementation it's installing the same resources declared in the helm chart, to avoid duplicating the setup we could set up a helm go client and install the chart in
helm/provisioner/
with some values defined in go code instead.I think https://manuelmazzuola.dev/2021/03/28/deploy-helm-chart-go is good starting point to use helm programatically, another way to accomplish the same is to install the helm/kubectl binaries in the script that creates the cluster that way we can call
helm debug | kubectl apply -f -
from within the testThe starting point for the test runner is our Prow job in test-infra which calls
make e2e
->hack/e2e.sh
->sig-storage-local-static-provisioner/hack/e2e.sh
Lines 318 to 324 in e0ad13e
if you have a cluster already running make sure to update the above lines to only run the test and not create/delete a cluster, i.e. remove
--up --down
The text was updated successfully, but these errors were encountered: