-
Notifications
You must be signed in to change notification settings - Fork 393
Open
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Description
Wile looking into shipping a kubectl create something plugin via krew I noticed that the - => _ rewriting in
krew/internal/installation/install.go
Line 242 in 48b3ea1
| name = strings.ReplaceAll(name, "-", "_") |
Background: kubectl allows these create plugins (and only those) since kubernetes/kubernetes#124123.
Basically we have this situation:
$ kubectl create-somethingmaps to the binarykubectl-create_something$ kubectl create somethingmaps to the binarykubectl-create-something- krew does the mentioned rewriting, turning the binary of the
create-somethingplugin into thekubectl-create_somethingbinary on disk (even though the binary in the plugin tar is properly named.
How could we allow to ship a kubectl-create-something binary?
xref https://kubernetes.slack.com/archives/CTJNMDM24/p1728488438493869
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
kind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.Indicates that an issue or PR should not be auto-closed due to staleness.priority/important-soonMust be staffed and worked on either currently, or very soon, ideally in time for the next release.Must be staffed and worked on either currently, or very soon, ideally in time for the next release.