Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow custom kwok instance-types at runtime #1848

Open
alec-rabold opened this issue Nov 27, 2024 · 2 comments
Open

allow custom kwok instance-types at runtime #1848

alec-rabold opened this issue Nov 27, 2024 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@alec-rabold
Copy link
Contributor

alec-rabold commented Nov 27, 2024

Description

What problem are you trying to solve?

When using the KWOK cloud-provider, I'd like to be able to pass a custom instance-types.json file at startup time (currently this required recompiling Karpenter from source).

A few immediate use-cases include:

  • tweaking node ephemeral-storage capacity
  • including / excluding "exotic" instance types
    (also custom naming for the instance types in metrics)

My hope is to be able to more easily run "experiments" with the above modifications before making those changes to a real cluster.

Started a PR for this feature here: #1847

How important is this feature to you?

This would make setting up a custom environment simpler, instead of needing a unique image for each combination of instance-types.

(as a side-note, it would be amazing if there was a publicly hosted karpenter-provider-kwok image 😄)


  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@alec-rabold alec-rabold added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 27, 2024
@jonathan-innis
Copy link
Member

Nice! Saw the PR and this seems great! Pretty annoying to have to recompile every time :)

@jonathan-innis
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants