standardize support features and conformance tests naming and formatting #2285
Replies: 2 comments 2 replies
-
One proposal for the supportFeatures naming could be
|
Beta Was this translation helpful? Give feedback.
-
Thanks for getting this started @LiorLieberman! My feedback here:
I think we should plan for all the routes to have sub features - we may or may not end up using them, but if we don't, we'll definitely need it.
|
Beta Was this translation helpful? Give feedback.
-
As part of #2163 I looked a bit into our current support features and conformance test, their names and their format.
There is a bit of a mess now and if we want to turn this into a part of our API, (as GEP 2162 proposes) we need to first define formatting rules, and adapt the current features and tests to conform those rules.
This discussion has a few goals;
Collaborate on the formatting rules for the support features and conformance test names. I will add a proposal in a follow up comment
Define what do we want to do with alpha apis. I did find we have a support feature for TLSRoute and for example but did not find one for GRPCRoute.
Also the one for TLS route is only one feature. Are we happy with it or we have sub features under the object that implementation can opt in? (like we have in HTTPRoute)
We have some features like
ReferenceGrant
that is shared across different objects. What happens if an implementation support reference grant forHTTPRoute
but not forTLSRoute
? (I might read the tests wrong, so do shout if this question does not make sense)I think we are missing quite a few core features (both for Gateway and for HTTPRoute), do we want to backfill them ? I opened a separate issue for it - Backfill core conformance features for core features #2284
Appreciate your feedback
Beta Was this translation helpful? Give feedback.
All reactions