Fix LabelSelector validation markers for map field (#1679) (#1717)

* Fix LabelSelector validation markers for map field

  Changed MinItems/MaxItems to
  MinProperties/MaxProperties for the
  MatchLabels field in LabelSelector, as it is a map type, not an array.
  This resolves controller-gen CRD generation
  errors.



* Add CRD generation to make generate target

Add controller-gen crd to the generate target to validate kubebuilder markers during development and CI runs.

Previously, make generate only ran controller-gen object, which generates DeepCopy methods but does not validate CRD markers like MinItems, MaxItems, MinProperties, etc. This meant invalid markers could be merged without detection, only to cause failures in downstream projects that run full CRD generation.

By adding CRD generation to the generate target:
- Invalid kubebuilder markers are caught immediately during development
- CI will fail if markers are incorrect or CRDs are out of sync
- Prevents downstream projects from encountering CRD generation errors
- Aligns with the target's existing documentation which states it generates CustomResourceDefinition objects

This change would have caught the MinItems/MaxItems issue fixed in commit 40cecfd before it was merged.



* Regenerate CRDs with updated validation markers

This regenerates the CRDs to include the MinProperties/MaxProperties
validation for the MatchLabels map field.

The generated CRD now includes:
- minProperties: 1
- maxProperties: 64

These properties correctly validate the map field, replacing the
incorrect MinItems/MaxItems markers that were causing controller-gen
failures.



---------

Signed-off-by: Killian Golds <[email protected]>
Co-authored-by: Killian Golds <[email protected]>

Author: danehans

Makefile

@@ -99,6 +99,7 @@ help: ## Display this help.
 .PHONY: generate
 generate: controller-gen code-generator ## Generate WebhookConfiguration, ClusterRole, CustomResourceDefinition objects, code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
 	$(CONTROLLER_GEN) object:headerFile="hack/boilerplate/boilerplate.generatego.txt" paths="./..."
+	$(CONTROLLER_GEN) crd output:dir="./config/crd/bases" paths="./..."
 	./hack/update-codegen.sh
 
 # Use same code-generator version as k8s.io/api

api/v1/shared_types.go

@@ -137,7 +137,7 @@ type LabelSelector struct {
 	// The matching logic is an AND operation on all entries.
 	//
 	// +required
-	// +kubebuilder:validation:MinItems=1
-	// +kubebuilder:validation:MaxItems=64
+	// +kubebuilder:validation:MinProperties=1
+	// +kubebuilder:validation:MaxProperties=64
 	MatchLabels map[LabelKey]LabelValue `json:"matchLabels,omitempty"`
 }

config/crd/bases/inference.networking.k8s.io_inferencepools.yaml

@@ -147,6 +147,8 @@ spec:
                       MatchLabels contains a set of required {key,value} pairs.
                       An object must match every label in this map to be selected.
                       The matching logic is an AND operation on all entries.
+                    maxProperties: 64
+                    minProperties: 1
                     type: object
                 required:
                 - matchLabels