Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cached clients return incomplete object lists for paginated list calls #3044

Open
chhsia0 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #3045
Open

Cached clients return incomplete object lists for paginated list calls #3044

chhsia0 opened this issue Dec 20, 2024 · 0 comments · May be fixed by #3045

Comments

@chhsia0
Copy link

chhsia0 commented Dec 20, 2024

Today, the cache reader does not support paginated list calls:

controller-runtime/pkg/cache/internal/cache_reader.go

Line 116 in aea2e32

return fmt.Errorf("continue list option is not supported by the cache")

However, in the initial list call, the cache reader does not return any signal to its callers to indicate whether the returned object list is incomplete:

controller-runtime/pkg/cache/internal/cache_reader.go

Line 149 in aea2e32

break

As a result, callers may have erroneous behaviors if it is assumed that the resulting list is complete. Till the technical challenge in #532 is resolved, it seems an error should be returned if there are too many objects.

Thoughts?
chhsia0 added a commit to chhsia0/controller-runtime that referenced this issue Dec 20, 2024
@chhsia0
fix: return error when object limit exceeded for cached list calls
cc3ad86 
Since the cache does not implement strongly consistent paginated list
calls, if the Limit option is set and the number of items listed exceeds
this limit, there is no way for the caller to get a complete list of
objects, so return an error here to notify the caller.

Fixes kubernetes-sigs#3044.
@chhsia0 chhsia0 linked a pull request Dec 20, 2024 that will close this issue
Open
chhsia0 added a commit to chhsia0/controller-runtime that referenced this issue Dec 20, 2024
@chhsia0
Return error when object limit exceeded for cached list calls
65ed581 
Since the cache does not implement strongly consistent paginated list
calls, if the Limit option is set and the number of items listed exceeds
this limit, there is no way for the caller to get a complete list of
objects, so return an error here to notify the caller.

Fixes kubernetes-sigs#3044.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 Return error when object limit exceeded for cached list calls chhsia0/controller-runtime
1 participant
@chhsia0