Merge pull request #2529 from kubernetes-sigs/speed-up

🏃 Make client.MatchingLabels faster
kubernetes-sigs · Oct 9, 2023 · 8ac8b9f · 8ac8b9f
2 parents 968daa8 + cb5be1f
commit 8ac8b9f
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/client/options.go b/pkg/client/options.go
@@ -514,7 +514,8 @@ type MatchingLabels map[string]string
 func (m MatchingLabels) ApplyToList(opts *ListOptions) {
 	// TODO(directxman12): can we avoid reserializing this over and over?
 	if opts.LabelSelector == nil {
-		opts.LabelSelector = labels.NewSelector()
+		opts.LabelSelector = labels.SelectorFromValidatedSet(map[string]string(m))
+		return
 	}
 	// If there's already a selector, we need to AND the two together.
 	noValidSel := labels.SelectorFromValidatedSet(map[string]string(m))