Skip to content

Second MD rolling update if a new MS was created at the same second as RolloutAfter #12260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sm4ll-3gg opened this issue May 21, 2025 · 1 comment · May be fixed by #12261
Open

Second MD rolling update if a new MS was created at the same second as RolloutAfter #12260

sm4ll-3gg opened this issue May 21, 2025 · 1 comment · May be fixed by #12261
Labels
area/machinedeployment Issues or PRs related to machinedeployments kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@sm4ll-3gg
Copy link

What steps did you take and what happened?

  • We updated CAPI v1.7.9 -> v1.9.5
  • A few MD was unexpectedly rolled out (ones with .spec.rolloutAfter == MS.metadata.creationTimestamp)

What did you expect to happen?

No MD should had been rolled out

Cluster API version

v1.9.5 (still relevant for the main branch and 1.10.x releases)

Kubernetes version

1.29

Anything else you would like to add?

MD controller, looking for a new MS, finds one that is created AFTER MD's .spec.rolloutAfter. The Time fileds are serialized with seconds accuracy (RFC3339), so, if a new MS was created at the same second as .spec.rolloutAfter, the controller will create a new.

Code examples:

Label(s) to be applied

/kind bug
/area machinedeployment

One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/machinedeployment Issues or PRs related to machinedeployments needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 21, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If CAPI contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/machinedeployment Issues or PRs related to machinedeployments kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants