Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Deprecate MD.Spec.ProgressDeadlineSeconds #11472

Merged
merged 1 commit into from
Dec 2, 2024
Merged

⚠️ Deprecate MD.Spec.ProgressDeadlineSeconds #11472

merged 1 commit into from
Dec 2, 2024
+11 −2

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

Fixes #11470

/area machinedeployment
/hold for consensus on the issue

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 25, 2024
@troy0820
Copy link
Member

/lgtm

Holding for consensus

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 99125b993a22d6b4987d7bbba255e0cf1823dc55

@fabriziopandini fabriziopandini force-pushed the deprecate-ProgressDeadlineSeconds branch from a5d8ad2 to 42297c1 Compare November 25, 2024 18:28
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 25, 2024
chrischdi
chrischdi reviewed Nov 28, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 28, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: faa294122cef1e8da9b22ce2d9c4079b2c8864ca

vincepri
vincepri approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 28, 2024
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-verify-main

@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fabriziopandini
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8fcde6a into kubernetes-sigs:main Dec 2, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Dec 2, 2024
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #11514

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 2, 2024
Merged
@fabriziopandini fabriziopandini deleted the deprecate-ProgressDeadlineSeconds branch December 2, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@vincepri vincepri vincepri approved these changes

@troy0820 troy0820 Awaiting requested review from troy0820

Assignees

@chrischdi chrischdi

@troy0820 troy0820

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machinedeployment Issues or PRs related to machinedeployments cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.

Remove spec.ProgressDeadlineSeconds in MachineDeployments
6 participants
@fabriziopandini @troy0820 @k8s-ci-robot @k8s-infra-cherrypick-robot @chrischdi @vincepri