Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove spec.ProgressDeadlineSeconds in MachineDeployments #11470

Open
fabriziopandini opened this issue Nov 25, 2024 · 3 comments · Fixed by #11472
Open

Remove spec.ProgressDeadlineSeconds in MachineDeployments #11470

fabriziopandini opened this issue Nov 25, 2024 · 3 comments · Fixed by #11472
Assignees
@fabriziopandini
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 25, 2024 •
edited
Loading

ProgressDeadlineSeconds field on MD is not used anywhere, so we probably should deprecate and remove it at the first chance

/kind cleanup
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 25, 2024
@fabriziopandini fabriziopandini added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 25, 2024
@fabriziopandini
Copy link
Member Author

cc @vincepri @enxebre who might have historical context on this field

@fabriziopandini fabriziopandini mentioned this issue Nov 25, 2024
Merged
@fabriziopandini fabriziopandini self-assigned this Nov 25, 2024
@fabriziopandini fabriziopandini changed the title Deprecate and remove ProgressDeadlineSeconds from Machine deployment Deprecate and remove spec.ProgressDeadlineSeconds in MachineDeployments Nov 25, 2024
@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Nov 27, 2024
@fabriziopandini fabriziopandini added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates an issue lacks a `priority/foo` label and requires one. label Nov 27, 2024
@sbueringer sbueringer mentioned this issue Dec 27, 2024
Open
59 tasks
@sbueringer
Copy link
Member

/reopen

field is deprecated, but not removed yet (also added to #10852)

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Reopened this issue.

In response to this:

/reopen

field is deprecated, but not removed yet (also added to #10852)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot reopened this Dec 27, 2024
@sbueringer sbueringer changed the title Deprecate and remove spec.ProgressDeadlineSeconds in MachineDeployments Remove spec.ProgressDeadlineSeconds in MachineDeployments Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziopandini fabriziopandini

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠️ Deprecate MD.Spec.ProgressDeadlineSeconds fabriziopandini/cluster-api
3 participants
@sbueringer @fabriziopandini @k8s-ci-robot