Skip to content

Implement support for kubeadm v1beta4 API #10708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
8 tasks done
Tracked by #10852 ...
fabriziopandini opened this issue May 30, 2024 · 9 comments · Fixed by #10709 or #12282
Closed
8 tasks done
Tracked by #10852 ...

Implement support for kubeadm v1beta4 API #10708

fabriziopandini opened this issue May 30, 2024 · 9 comments · Fixed by #10709 or #12282
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented May 30, 2024

What would you like to be added (User Story)?

As a user, I want to be able to create clusters with kubeadm 1.31 (which most probably is going to use v1beta4 API)
As a user, I want to be able to use latest and greatest introduced by kubeadm v1beta4 API

rif kubernetes/kubernetes#125029

Action Plan

Mandatory tasks to support Kubernetes v1.31:

  • Implements conversions from CAPI v1beta1 types to kubeadm v1beta4 ✨ Add kubeadm v1beta4 types #10709
    • Special handling should be implemented for ClusterConfiguration.TimeoutForControlPlane and JoinConfiguration.Discovery.Timeout

Optional non breaking changes to be implemented ASAP:

Changes deferred to when we implemening CAPI v1beta2 types

Changes deferred to when we review certificate management / renewal --> #12289

Changes deferred to when we review kubeadm/KCP addon management --> #12288

Changes deferred to when we implement EncryptionAlgorithm for certificates -> #10077

Label(s) to be applied

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates an issue lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 30, 2024
@fabriziopandini
Copy link
Member Author

/priority important-soon
note: priority assumes we can continue to work with v1beta3 API, but if this is not true it must be bumped to critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates an issue lacks a `priority/foo` label and requires one. labels May 30, 2024
@sbueringer
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 6, 2024
@sbueringer
Copy link
Member

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 7, 2024
@sbueringer sbueringer removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 11, 2025
@chrischdi chrischdi added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 5, 2025
@superbrothers
Copy link
Contributor

superbrothers commented May 21, 2025

Add Init/JoinConfiguration.Timeout

Is it possible to work on the above task now?

Our cluster has a large etcd db, which causes the learner to fail to promote to follower, so we have disabled kubeadm EtcdLearnerMode. However, this option was removed in v1.33 with GA. Therefore, we would like to use timeouts.etcdAPICall.

@sbueringer
Copy link
Member

@fabriziopandini is just now taking a closer look at this issue and at least implement some part of it. (I let him respond if what you are asking for is covered there or not)

@fabriziopandini
Copy link
Member Author

#12282 implements changes for extra args, timeouts and image pull polices

Other changes with broader impacts on other CAPI features are tracked in separated issues:

Certificate management / renewal --> #12289

Proxy and DNS installation and management --> #12288

Support more EncryptionAlgorithm for certificates -> #10077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
6 participants