fix: parseProviderName

Signed-off-by: sivchari <[email protected]>

Author: sivchari

cmd/clusterctl/client/common.go

@@ -62,7 +62,7 @@ func (c *clusterctlClient) getComponentsByName(ctx context.Context, provider str
 
 // parseProviderName defines a utility function that parses the abbreviated syntax for name[:version].
 func parseProviderName(provider string) (name string, version string, err error) {
-	t := strings.Split(strings.ToLower(provider), ":")
+	t := strings.Split(provider, ":")
 	if len(t) > 2 {
 		return "", "", errors.Errorf("invalid provider name %q. Provider name should be in the form name[:version]", provider)
 	}
@@ -71,7 +71,7 @@ func parseProviderName(provider string) (name string, version string, err error)
 		return "", "", errors.Errorf("invalid provider name %q. Provider name should be in the form name[:version] and name cannot be empty", provider)
 	}
 
-	name = t[0]
+	name = strings.ToLower(t[0])
 	if err := validateDNS1123Label(name); err != nil {
 		return "", "", errors.Wrapf(err, "invalid provider name %q. Provider name should be in the form name[:version] and the name should be valid", provider)
 	}

cmd/clusterctl/client/common_test.go

@@ -51,6 +51,24 @@ func Test_parseProviderName(t *testing.T) {
 			wantVersion: "version",
 			wantErr:     false,
 		},
+		{
+			name: "name & upper case version",
+			args: args{
+				provider: "provider:1.0.0-VERSION",
+			},
+			wantName:    "provider",
+			wantVersion: "1.0.0-VERSION",
+			wantErr:     false,
+		},
+		{
+			name: "upper name & version",
+			args: args{
+				provider: "PROVIDER:VERSION",
+			},
+			wantName:    "provider",
+			wantVersion: "VERSION",
+			wantErr:     false,
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
@@ -59,9 +77,9 @@ func Test_parseProviderName(t *testing.T) {
 			gotName, gotVersion, err := parseProviderName(tt.args.provider)
 			if tt.wantErr {
 				g.Expect(err).To(HaveOccurred())
-			} else {
-				g.Expect(err).ToNot(HaveOccurred())
+				return
 			}
+			g.Expect(err).ToNot(HaveOccurred())
 			g.Expect(gotName).To(Equal(tt.wantName))
 
 			g.Expect(gotVersion).To(Equal(tt.wantVersion))