Fix lint

Signed-off-by: Lubron Zhan <[email protected]>

Author: lubronzhan

api/v1beta2/cluster_types.go

@@ -916,7 +916,7 @@ type NodeDeletionStrategyType string
 const (
 	// NodeDeletionStrategyForce defines a force type strategy that node will be deleted immediately without drain.
 	NodeDeletionStrategyForce NodeDeletionStrategyType = "force"
-	// NodeDeletionStrategyTypeGracefulWithTimeout defines a force type strategy that node will be deleted with drain.
+	// NodeDeletionStrategyGracefulWithTimeout defines a force type strategy that node will be deleted with drain.
 	NodeDeletionStrategyGracefulWithTimeout NodeDeletionStrategyType = "gracefulWithTimeout"
 )
 

internal/controllers/machine/machine_controller.go

@@ -715,7 +715,7 @@ func (r *Reconciler) nodeVolumeDetachTimeoutExceeded(machine *clusterv1.Machine)
 func (r *Reconciler) isDeleteNodeAllowed(ctx context.Context, cluster *clusterv1.Cluster, machine *clusterv1.Machine) error {
 	log := ctrl.LoggerFrom(ctx)
 	// Return early if the cluster is being deleted and cluster's nodeDeletionStrategy is not set or set to `force`.
-	if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology.NodeDeletionStrategy == nil || *cluster.Spec.Topology.NodeDeletionStrategy == clusterv1.NodeDeletionStrategyForce) {
+	if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology == nil || cluster.Spec.Topology.NodeDeletionStrategy == nil || *cluster.Spec.Topology.NodeDeletionStrategy == clusterv1.NodeDeletionStrategyForce) {
 		return errClusterIsBeingDeleted
 	}