Skip to content

Commit 1b05729

Browse files
committed
Resolve conversion test failure
Signed-off-by: Lubron Zhan <[email protected]>
1 parent d5ac066 commit 1b05729

File tree

3 files changed

+11
-8
lines changed

3 files changed

+11
-8
lines changed

api/v1beta1/conversion.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -574,7 +574,10 @@ func Convert_v1beta1_Condition_To_v1_Condition(_ *Condition, _ *metav1.Condition
574574
return nil
575575
}
576576

577-
// Convert_v1beta2_Topology_To_v1beta1_Topology is an autogenerated conversion function.
578577
func Convert_v1beta2_Topology_To_v1beta1_Topology(in *clusterv1.Topology, out *Topology, s apimachineryconversion.Scope) error {
579-
return autoConvert_v1beta2_Topology_To_v1beta1_Topology(in, out, s)
578+
if err := autoConvert_v1beta2_Topology_To_v1beta1_Topology(in, out, s); err != nil {
579+
return err
580+
}
581+
582+
return nil
580583
}

api/v1beta1/zz_generated.conversion.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/controllers/machine/machine_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -715,7 +715,7 @@ func (r *Reconciler) nodeVolumeDetachTimeoutExceeded(machine *clusterv1.Machine)
715715
func (r *Reconciler) isDeleteNodeAllowed(ctx context.Context, cluster *clusterv1.Cluster, machine *clusterv1.Machine) error {
716716
log := ctrl.LoggerFrom(ctx)
717717
// Return early if the cluster is being deleted and cluster's nodeDeletionStrategy is not set or set to `force`.
718-
if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology == nil || cluster.Spec.Topology.NodeDeletionStrategy == clusterv1.NodeDeletionStrategyForce) {
718+
if !cluster.DeletionTimestamp.IsZero() && (cluster.Spec.Topology == nil || cluster.Spec.Topology.NodeDeletionStrategy != clusterv1.NodeDeletionStrategyGraceful) {
719719
return errClusterIsBeingDeleted
720720
}
721721

0 commit comments

Comments
 (0)