Validate fstype on CreateVolume, but not NodePublishVolume #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are existing PVs that could have wrong fstype, this change tries to workaround this to validate fstype during CreateVolume for new volumes, not on NodePublishVolume
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
wongma7
reviewed
Jun 7, 2023
|
@mskanth972 adding Shashi into the PR review loop as well |
|
/approve will let other maintainers have a chance to lgtm 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jingxu97, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Just a friendly ping for review. @Ashley-wenyizha @mskanth972 @leakingtapan could you help review and lgtm? Thank you! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
bug
#1025
What is this PR about? / Why do we need it?
There are existing PVs that could have wrong fstype, adding new validation will break it. This change tries to workaround this to validate fstype during CreateVolume for new volumes, not on NodePublishVolume
What testing is done?
unit test