-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining broken links (remove from todoPatterns
)
#3960
Comments
/help |
@varodrig: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi, I tried removing all the entries from the I am not getting any error just 2 warnings, let me know if I am missing anything to reproduce this issue. |
@jaiakash can you make a PR into the |
Sure @thesuperzapper i have raised PR for same, I think for some 6 tests are failing, i will try adding them. |
Since adding the
netlify-plugin-checklinks
plugin, we have been slowly working through all the links on the website to ensure they are all valid.We still have a number of links marked as
todoPatterns
(and therefore don't fail the build). We should aim to remove all entries fromtodoPatterns
and fix any broken links targeting these paths:website/netlify.toml
Lines 29 to 50 in f82061c
NOTE: if some of the TODO links are actually correct but the plugin is making a mistake, we can use the
skipPatterns
section instead, so they don't appear in the logs.The text was updated successfully, but these errors were encountered: