Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining broken links (remove from todoPatterns) #3960

Closed
thesuperzapper opened this issue Jan 15, 2025 · 5 comments · Fixed by #3963
Closed

Fix remaining broken links (remove from todoPatterns) #3960

thesuperzapper opened this issue Jan 15, 2025 · 5 comments · Fixed by #3963
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@thesuperzapper
Copy link
Member

Since adding the netlify-plugin-checklinks plugin, we have been slowly working through all the links on the website to ensure they are all valid.

We still have a number of links marked as todoPatterns (and therefore don't fail the build). We should aim to remove all entries from todoPatterns and fix any broken links targeting these paths:

website/netlify.toml

Lines 29 to 50 in f82061c

todoPatterns = [
# These are referenced by autogenerated files:
"public/docs/components/pipelines/legacy-v1/reference/api/fonts/",
"public/docs/components/pipelines/reference/api/fonts/",
"public/docs/components/pipelines/fonts/",
"public/docs/components/pipelines/legacy-v1/fonts/",
"public/docs/distributions/gke/",
"public/docs/distributions/aws/",
"public/docs/distributions/ibm/",
"public/fonts/glyphicons",
"public/docs/experiment",
"public/docs/suggestion",
"public/docs/trial",
"public/docs/examples/shared-resources",
"public/docs/started/getting-started",
"public/docs/other-guides",
"public/docs/external-add-ons/istio",
]

NOTE: if some of the TODO links are actually correct but the plugin is making a mistake, we can use the skipPatterns section instead, so they don't appear in the logs.

@varodrig
Copy link
Contributor

/help

Copy link

@varodrig:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot added the help wanted Extra attention is needed label Jan 16, 2025
@thesuperzapper thesuperzapper pinned this issue Jan 17, 2025
@thesuperzapper thesuperzapper added the good first issue Good for newcomers label Jan 17, 2025
@thesuperzapper thesuperzapper unpinned this issue Jan 17, 2025
@jaiakash
Copy link
Contributor

Hi, I tried removing all the entries from the todoPatterns, but there was no issue showing on the Netlify build. You can check the project at https://github.com/jaiakash/website/tree/netlfiy-test and the deployed website at https://kubeflowwebsite.netlify.app/

I am not getting any error just 2 warnings, let me know if I am missing anything to reproduce this issue.
Image

@thesuperzapper
Copy link
Member Author

@jaiakash can you make a PR into the kubeflow/website repo that removes the ones you think are ok, and then we will see if the build succeeds on the real website (in the PR status)?

@jaiakash
Copy link
Contributor

jaiakash commented Jan 18, 2025

Sure @thesuperzapper i have raised PR for same, I think for some 6 tests are failing, i will try adding them.

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants