We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Once #2502 is resolved, we can remove Launcher chainer function from JobSet plugin since validations always check the rJob replicas.
Launcher
trainer/pkg/runtime/framework/plugins/jobset/builder.go
Lines 104 to 114 in 4b0c294
trainer/pkg/runtime/framework/plugins/jobset/jobset.go
Line 197 in 4b0c294
Validations always check the rJob replicas. So, overriding the Lacunher replicas is not needed.
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered:
@IRONICBo Would you mind taking this issue? After your current PR, this will be unblocked.
Sorry, something went wrong.
@tenzen-y Yes, I want to take it.
/assign
Thank you
IRONICBo
Successfully merging a pull request may close this issue.
What you would like to be added?
Once #2502 is resolved, we can remove
Launcher
chainer function from JobSet plugin since validations always check the rJob replicas.trainer/pkg/runtime/framework/plugins/jobset/builder.go
Lines 104 to 114 in 4b0c294
trainer/pkg/runtime/framework/plugins/jobset/jobset.go
Line 197 in 4b0c294
Why is this needed?
Validations always check the rJob replicas.
So, overriding the Lacunher replicas is not needed.
Love this feature?
Give it a 👍 We prioritize the features with most 👍
The text was updated successfully, but these errors were encountered: