Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Launcher chainer from JobSet plugin #2554

Closed
tenzen-y opened this issue Mar 21, 2025 · 4 comments · Fixed by #2558
Closed

Remove Launcher chainer from JobSet plugin #2554

tenzen-y opened this issue Mar 21, 2025 · 4 comments · Fixed by #2558
Assignees

Comments

@tenzen-y
Copy link
Member

What you would like to be added?

Once #2502 is resolved, we can remove Launcher chainer function from JobSet plugin since validations always check the rJob replicas.

// Launcher updates JobSet values for the launcher Job.
func (b *Builder) Launcher(info *runtime.Info, trainJob *trainer.TrainJob) *Builder {
for i, rJob := range b.Spec.ReplicatedJobs {
if *rJob.Name == constants.Launcher {
// TODO: Support multiple replicas ('.template.spec.replicatedJobs[*].replicas') for replicated Jobs.
// REF: https://github.com/kubeflow/trainer/issues/2318
b.Spec.ReplicatedJobs[i].Replicas = ptr.To[int32](1)
}
}
return b
}

Launcher(info, trainJob).

Why is this needed?

Validations always check the rJob replicas.
So, overriding the Lacunher replicas is not needed.

Love this feature?

Give it a 👍 We prioritize the features with most 👍

@tenzen-y
Copy link
Member Author

@IRONICBo Would you mind taking this issue? After your current PR, this will be unblocked.

@IRONICBo
Copy link
Contributor

IRONICBo commented Mar 21, 2025

@tenzen-y Yes, I want to take it.

@IRONICBo
Copy link
Contributor

/assign

@tenzen-y
Copy link
Member Author

@tenzen-y Yes, I want to take it.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants