Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AutoMenus in ComponentPlan #91

Open
bjwswang opened this issue Jul 11, 2023 · 3 comments
Open

Add AutoMenus in ComponentPlan #91

bjwswang opened this issue Jul 11, 2023 · 3 comments
Assignees
Labels
difficulty-medium Normal amount of changes, no design detail adjustments enhancement New feature or request priority-low
Milestone

Comments

@bjwswang
Copy link
Collaborator

bjwswang commented Jul 11, 2023

Add a new field AutoMenus bool. When AutoMenus is true, process menus.json and create the Menus

@bjwswang bjwswang modified the milestones: v0.2.0, v0.1.2 Jul 12, 2023
@Abirdcfly Abirdcfly self-assigned this Jul 17, 2023
@bobsongplus
Copy link

I am interested in this feature. Could you assign it to me?

@Abirdcfly Abirdcfly assigned bobsongplus and unassigned Abirdcfly Jul 21, 2023
@bjwswang bjwswang added enhancement New feature or request difficulty-medium Normal amount of changes, no design detail adjustments labels Jul 21, 2023
@bjwswang
Copy link
Collaborator Author

@Carrotzpc why menu.json instead of menu.yaml?

@Carrotzpc
Copy link

The new version of the Menu CRD has deprecated parentOwnerReferences and now uses Kubernetes' built-in ownerReferences to define hierarchical relationships. You can no longer directly apply the "menu.yaml" file to create all the menu components as before. Instead, you need to create the parent menu first, obtain the UID of the parent menu, define the ownerReferences, and then create the child menus. In other words, you need to implement the menu creation programmatically. Therefore, there is no need to convert the menu to YAML for CR; "menu.json" itself represents the definition in the Menu CR's spec. The "bff-server" has implemented an API to create menus using "menu.json". Let's explore the possibility of directly invoking the "bff-server" API to achieve this.

@bjwswang bjwswang removed this from the v0.1.2 milestone Jul 27, 2023
@bjwswang bjwswang added this to the v0.3.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty-medium Normal amount of changes, no design detail adjustments enhancement New feature or request priority-low
Projects
None yet
Development

No branches or pull requests

4 participants