refactor(manifests): use full web application resource names

Signed-off-by: alokdangre <alokdangre@gmail.com>

Author: alokdangre

.github/workflows/test-manifests.yaml

@@ -10,7 +10,7 @@ permissions:
   actions: read
 
 jobs:
-  test-models-web-app:
+  test-models-web-application:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Models Web Application
@@ -50,6 +50,10 @@ jobs:
           cp -R models-web-app/manifests/kustomize/components manifests/applications/kserve/models-web-app/
           cp -R models-web-app/manifests/kustomize/overlays manifests/applications/kserve/models-web-app/
 
+      - name: Align kubeflow/manifests KServe install test with renamed deployment
+        run: |
+          sed -i 's/kserve-models-web-app/kserve-models-web-application/g' manifests/tests/kserve_install.sh
+
       - name: Install Istio CNI
         working-directory: manifests
         run: ./tests/istio-cni_install.sh
@@ -90,7 +94,7 @@ jobs:
       - name: Wait for KServe Models Web Application deployment
         run: |
           kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout=300s --field-selector=status.phase!=Succeeded
-          kubectl wait --for=condition=Available deployment/kserve-models-web-app -n kubeflow --timeout=60s
+          kubectl wait --for=condition=Available deployment/kserve-models-web-application -n kubeflow --timeout=60s
           sleep 10
 
       - name: Setup python 3.12
@@ -108,9 +112,9 @@ jobs:
       - name: Debug KServe Models Web Application connectivity
         if: failure()
         run: |
-          kubectl get deployment,service,endpoints,pods -n kubeflow -l app.kubernetes.io/component=kserve-models-web-app || true
-          kubectl describe deployment kserve-models-web-app -n kubeflow || true
-          kubectl logs deployment/kserve-models-web-app -n kubeflow --all-containers=true --tail=200 || true
+          kubectl get deployment,service,endpoints,pods -n kubeflow -l app.kubernetes.io/component=kserve-models-web-application || true
+          kubectl describe deployment kserve-models-web-application -n kubeflow || true
+          kubectl logs deployment/kserve-models-web-application -n kubeflow --all-containers=true --tail=200 || true
 
       - name: Apply Pod Security Standards restricted levels
         working-directory: manifests

README.md

@@ -38,7 +38,7 @@ CONFIG=manifests/kustomize/base/kustomization.yaml
 vim ${CONFIG}
 
 # Add the following env vars to the configMapGenerator's literals
-# for kserve-models-web-app-config
+# for kserve-models-web-application-config
 - APP_PREFIX=/
 - APP_DISABLE_AUTH="True"
 - APP_SECURE_COOKIES="False"
@@ -95,12 +95,12 @@ Add the environment variable to your deployment configuration:
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
 spec:
   template:
     spec:
       containers:
-      - name: kserve-models-web-app
+      - name: kserve-models-web-application
         env:
         - name: ALLOWED_NAMESPACES
           value: "kubeflow-user,kubeflow-admin"
@@ -110,7 +110,7 @@ spec:
 
 The application supports runtime configuration of Grafana endpoints and dashboard names, allowing you to use custom Grafana instances and dashboard configurations without rebuilding the application.
 
-If you're deploying on Kubernetes with Kustomize, you can set these values in the application's ConfigMap by editing the `manifests/kustomize/base/kustomization.yaml` (or your overlay) under `configMapGenerator` for `kserve-models-web-app-config`. Update the following literals as needed:
+If you're deploying on Kubernetes with Kustomize, you can set these values in the application's ConfigMap by editing the `manifests/kustomize/base/kustomization.yaml` (or your overlay) under `configMapGenerator` for `kserve-models-web-application-config`. Update the following literals as needed:
 
 - `GRAFANA_PREFIX` (e.g., `/grafana` or `/custom-grafana`)
 - `GRAFANA_CPU_MEMORY_DB` (e.g., `db/custom-cpu-memory-dashboard`)

manifests/kustomize/base/deployment.yaml

@@ -1,17 +1,17 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   replicas: 1
   selector:
     matchLabels:
-      app.kubernetes.io/component: kserve-models-web-app
+      app.kubernetes.io/component: kserve-models-web-application
   template:
     metadata:
       labels:
-        app.kubernetes.io/component: kserve-models-web-app
+        app.kubernetes.io/component: kserve-models-web-application
     spec:
       securityContext:
         runAsNonRoot: true
@@ -20,13 +20,13 @@ spec:
       containers:
         - image: kserve/models-web-app:latest
           imagePullPolicy: Always
-          name: kserve-models-web-app
+          name: kserve-models-web-application
           env:
             - name: GUNICORN_CMD_ARGS
               value: --limit-request-field_size 32000
           envFrom:
             - configMapRef:
-                name: kserve-models-web-app-config
+                name: kserve-models-web-application-config
           ports:
             - containerPort: 5000
               name: http
@@ -54,4 +54,4 @@ spec:
               drop:
                 - ALL
             runAsUser: 1000
-      serviceAccountName: kserve-models-web-app
+      serviceAccountName: kserve-models-web-application

manifests/kustomize/base/kustomization.yaml

@@ -14,11 +14,11 @@ configMapGenerator:
       - GRAFANA_PREFIX="/grafana"
       - GRAFANA_CPU_MEMORY_DB="db/knative-serving-revision-cpu-and-memory-usage"
       - GRAFANA_HTTP_REQUESTS_DB="db/knative-serving-revision-http-requests"
-    name: kserve-models-web-app-config
+    name: kserve-models-web-application-config
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 labels:
   - includeSelectors: true
     pairs:
-      app.kubernetes.io/component: kserve-models-web-app
-      kustomize.component: kserve-models-web-app
+      app.kubernetes.io/component: kserve-models-web-application
+      kustomize.component: kserve-models-web-application

manifests/kustomize/base/rbac.yaml

@@ -1,13 +1,13 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  name: kserve-models-web-app-cluster-role
+  name: kserve-models-web-application-cluster-role
 rules:
 - apiGroups:
   - authorization.k8s.io
@@ -57,12 +57,12 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name: kserve-models-web-app-binding
+  name: kserve-models-web-application-binding
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: kserve-models-web-app-cluster-role
+  name: kserve-models-web-application-cluster-role
 subjects:
 - kind: ServiceAccount
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve

manifests/kustomize/base/service.yaml

@@ -1,7 +1,7 @@
 apiVersion: v1
 kind: Service
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   ports:
@@ -10,5 +10,5 @@ spec:
     protocol: TCP
     targetPort: 5000
   selector:
-    app.kubernetes.io/component: kserve-models-web-app
+    app.kubernetes.io/component: kserve-models-web-application
   type: ClusterIP

manifests/kustomize/components/common/kustomization.yaml

@@ -5,5 +5,5 @@ labels:
   - includeSelectors: false
     pairs:
       app.kubernetes.io/managed-by: kustomize
-      app.kubernetes.io/name: models-web-app
-      app.kubernetes.io/part-of: models-web-app
+      app.kubernetes.io/name: models-web-application
+      app.kubernetes.io/part-of: models-web-application

manifests/kustomize/components/istio/authorization-policy.yaml

@@ -2,15 +2,15 @@ apiVersion: security.istio.io/v1beta1
 kind: AuthorizationPolicy
 metadata:
   labels:
-    kustomize.component: kserve-models-web-app
-    app.kubernetes.io/component: kserve-models-web-app
-  name: kserve-models-web-app
+    kustomize.component: kserve-models-web-application
+    app.kubernetes.io/component: kserve-models-web-application
+  name: kserve-models-web-application
 spec:
   action: ALLOW
   selector:
     matchLabels:
-      kustomize.component: kserve-models-web-app
-      app.kubernetes.io/component: kserve-models-web-app
+      kustomize.component: kserve-models-web-application
+      app.kubernetes.io/component: kserve-models-web-application
   rules:
   - from:
     - source:

manifests/kustomize/components/istio/virtual-service.yaml

@@ -1,7 +1,7 @@
 apiVersion: networking.istio.io/v1beta1
 kind: VirtualService
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   gateways:
@@ -16,6 +16,6 @@ spec:
       uri: /
     route:
     - destination:
-        host: kserve-models-web-app.kserve.svc.cluster.local
+        host: kserve-models-web-application.kserve.svc.cluster.local
         port:
           number: 80

manifests/kustomize/components/istio/web-app-sidecar.yaml

@@ -1,7 +1,7 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   template: