refactor(manifests): use full deployment and service account names

Signed-off-by: alokdangre <alokdangre@gmail.com>

Author: alokdangre

.github/workflows/test-manifests.yaml

@@ -10,7 +10,7 @@ permissions:
   actions: read
 
 jobs:
-  test-models-web-app:
+  test-models-web-application:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout Models Web Application
@@ -50,6 +50,10 @@ jobs:
           cp -R models-web-app/manifests/kustomize/components manifests/applications/kserve/models-web-app/
           cp -R models-web-app/manifests/kustomize/overlays manifests/applications/kserve/models-web-app/
 
+      - name: Align kubeflow/manifests KServe install test with renamed deployment
+        run: |
+          sed -i 's#deployment/kserve-models-web-app#deployment/kserve-models-web-application#g' manifests/tests/kserve_install.sh
+
       - name: Install Istio CNI
         working-directory: manifests
         run: ./tests/istio-cni_install.sh
@@ -90,7 +94,7 @@ jobs:
       - name: Wait for KServe Models Web Application deployment
         run: |
           kubectl wait --for=condition=Ready pods --all --all-namespaces --timeout=300s --field-selector=status.phase!=Succeeded
-          kubectl wait --for=condition=Available deployment/kserve-models-web-app -n kubeflow --timeout=60s
+          kubectl wait --for=condition=Available deployment/kserve-models-web-application -n kubeflow --timeout=60s
           sleep 10
 
       - name: Setup python 3.12
@@ -109,8 +113,8 @@ jobs:
         if: failure()
         run: |
           kubectl get deployment,service,endpoints,pods -n kubeflow -l app.kubernetes.io/component=kserve-models-web-app || true
-          kubectl describe deployment kserve-models-web-app -n kubeflow || true
-          kubectl logs deployment/kserve-models-web-app -n kubeflow --all-containers=true --tail=200 || true
+          kubectl describe deployment kserve-models-web-application -n kubeflow || true
+          kubectl logs deployment/kserve-models-web-application -n kubeflow --all-containers=true --tail=200 || true
 
       - name: Apply Pod Security Standards restricted levels
         working-directory: manifests

README.md

@@ -95,12 +95,12 @@ Add the environment variable to your deployment configuration:
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
 spec:
   template:
     spec:
       containers:
-      - name: kserve-models-web-app
+      - name: kserve-models-web-application
         env:
         - name: ALLOWED_NAMESPACES
           value: "kubeflow-user,kubeflow-admin"

manifests/kustomize/base/deployment.yaml

@@ -1,7 +1,7 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   replicas: 1
@@ -54,4 +54,4 @@ spec:
               drop:
                 - ALL
             runAsUser: 1000
-      serviceAccountName: kserve-models-web-app
+      serviceAccountName: kserve-models-web-application

manifests/kustomize/base/rbac.yaml

@@ -1,13 +1,13 @@
 apiVersion: v1
 kind: ServiceAccount
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
-  name: kserve-models-web-app-cluster-role
+  name: kserve-models-web-application-cluster-role
 rules:
 - apiGroups:
   - authorization.k8s.io
@@ -57,12 +57,12 @@ rules:
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding
 metadata:
-  name: kserve-models-web-app-binding
+  name: kserve-models-web-application-binding
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: ClusterRole
-  name: kserve-models-web-app-cluster-role
+  name: kserve-models-web-application-cluster-role
 subjects:
 - kind: ServiceAccount
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve

manifests/kustomize/components/istio/web-app-sidecar.yaml

@@ -1,7 +1,7 @@
 apiVersion: apps/v1
 kind: Deployment
 metadata:
-  name: kserve-models-web-app
+  name: kserve-models-web-application
   namespace: kserve
 spec:
   template:

manifests/tests/kserve_test.sh

@@ -110,7 +110,7 @@ fi
 # ============================================================
 # Test 3: KServe Models Web Application API
 # ============================================================
-kubectl wait --for=condition=Available --timeout=300s -n kubeflow deployment/kserve-models-web-app
+kubectl wait --for=condition=Available --timeout=300s -n kubeflow deployment/kserve-models-web-application
 
 TOKEN="$(kubectl -n ${NAMESPACE} create token default-editor)"
 BASE_URL="localhost:8080/kserve-endpoints"