Skip to content

Commit 1a64e84

Browse files
danish9039alokdangre
authored andcommitted
ci: use kserve_install.sh for ClusterServingRuntimes, bump timeout to 25m
Signed-off-by: danish9039 <danishsiddiqui040@gmail.com> Signed-off-by: alokdangre <alokdangre@gmail.com>
1 parent f111846 commit 1a64e84

File tree

1 file changed

+13
-22
lines changed

1 file changed

+13
-22
lines changed

.github/workflows/test-manifests.yaml

Lines changed: 13 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,15 @@ env:
1515
jobs:
1616
build:
1717
runs-on: ubuntu-latest
18-
timeout-minutes: 15
18+
timeout-minutes: 25
1919
steps:
2020
- name: Checkout kserve/models-web-app
21-
uses: actions/checkout@v4
21+
uses: actions/checkout@v5
2222

23-
- name: Checkout kubeflow/manifests at one-line fix SHA
24-
uses: actions/checkout@v4
23+
- name: Checkout kubeflow/manifests
24+
uses: actions/checkout@v5
2525
with:
26-
repository: danish9039/manifests
27-
ref: fee48d517e04c333163c6c06e4c799ee34547862
26+
repository: kubeflow/manifests
2827
path: kubeflow-manifests
2928

3029
- name: Install KinD, Create KinD cluster and Install kustomize
@@ -58,24 +57,16 @@ jobs:
5857
working-directory: kubeflow-manifests
5958
run: ./tests/knative_install.sh
6059

61-
- name: Install KServe core from kubeflow/manifests
62-
run: |
63-
cd kubeflow-manifests
64-
set +e
65-
for i in 1 2 3; do
66-
kustomize build applications/kserve/kserve | kubectl apply --server-side --force-conflicts -f - && break
67-
sleep 10
68-
done
69-
set -e
70-
kubectl wait --for=condition=established --timeout=60s \
71-
crd/clusterservingruntimes.serving.kserve.io
60+
- name: Install KServe (core + ClusterServingRuntimes)
61+
working-directory: kubeflow-manifests
62+
run: ./tests/kserve_install.sh
7263

73-
- name: Install KServe Models Web App from THIS PR manifests
64+
- name: Override models web app with THIS PR manifests
7465
run: |
7566
kustomize build manifests/kustomize/overlays/kubeflow | \
7667
kubectl apply --server-side --force-conflicts -f -
77-
kubectl wait --for=condition=Ready pods --all --all-namespaces \
78-
--timeout=600s --field-selector=status.phase!=Succeeded
68+
kubectl rollout status deployment/kserve-models-web-application \
69+
-n kubeflow --timeout=120s
7970
kubectl wait --for=condition=Available \
8071
deployment/kserve-models-web-application \
8172
-n kubeflow --timeout=60s
@@ -85,7 +76,7 @@ jobs:
8576
run: ./tests/kubeflow_profile_install.sh
8677

8778
- name: Setup python 3.12
88-
uses: actions/setup-python@v4
79+
uses: actions/setup-python@v5
8980
with:
9081
python-version: 3.12
9182

@@ -125,7 +116,7 @@ jobs:
125116
126117
- name: Upload Diagnostic Logs
127118
if: always()
128-
uses: actions/upload-artifact@v4
119+
uses: actions/upload-artifact@v5
129120
with:
130121
name: kserve-models-web-app-test-logs
131122
path: logs/

0 commit comments

Comments
 (0)