[Bug] Empty text causes line number to be cut off

[edonv]

I haven't tried on iOS, but on macOS with both SwiftUI and AppKit versions, if line numbers are enabled and the text is an empty string, the first (and only) line number is aligned weirdly and is cut off. No extra customization has been done.

Any ideas?

(P.S. I missed the checkbox before posting, but yes, I couldn't find mention of the same issue.)

[krzyzanowskim]

that location looks off. The empty document infers the height, font and whatnot from the current typing attributes, which is derived from the default font.

if you do something like

textView.font = NSFont.monospacedSystemFont(ofSize: 0, weight: .regular)

that is, set default font, that should fix it.

Nonetherless the problem is that if default font is not set, defaults gives unexpected result. That is something to be fixed here.

[edonv]

Ok so while I did test this with nothing customized, the screenshot actually has essentially that same thing set on it:

textView.font = NSFont.monospacedSystemFont(ofSize: NSFont.systemFontSize, weight: .regular)

I'm primarily going to be using it in AppKit and, as it stands, I won't be using NSAttributedString either.

I have the font being set before the text is set should be before any text is set, and this happens anytime I clear the text back to empty. I did some view hierarchy debugging and the line number view is the right height, but the number is just aligning its center vertically against the top of the row.

[krzyzanowskim]

I only quickly checked on the demo project

STTextView/TextEdit/Mac/ViewController.swift

Line 29 in 018dfdd

textView.font = NSFont.monospacedSystemFont(ofSize: 0, weight: .regular)

so maybe I'm missing something else. Can you share your setup?

[edonv]

Found the issue! I hadn't set a value to defaultParagraphStyle. I just tried adding what you have in the demo and that fixed it. Would it be worth updating the default value? I see it uses NSParagraphStyle.default, which itself has a value of 0 for lineHeightMultiple. So if you're using that value for something related to the vertical alignment of the line number when there is no text, that could be the issue.

[krzyzanowskim]

I see it uses NSParagraphStyle.default, which itself has a value of 0 for lineHeightMultiple

good find. That needs a fix to handle it better with default values.

[krzyzanowskim]

Fixed