PHP 8.4 deprecations & minimum versions bump (#733)

Author: rudiedirkx

.github/workflows/test.yml

@@ -15,17 +15,11 @@ jobs:
       max-parallel: 6 # 12
       fail-fast: false
       matrix:
-        laravel: [9, 10, 11]
-        php: ['8.1', '8.2', '8.3']
-        phpunit: [9, 10]
+        laravel: [10, 11]
+        php: ['8.2', '8.3', '8.4']
+        phpunit: [10]
         exclude:
-          - {laravel: 11, php: '8.1'}
-          - {laravel: 9, phpunit: 10}
-          - {phpunit: 9}
-        include:
-          - {laravel: 9, php: '8.1', phpunit: 9}
-          - {laravel: 9, php: '8.2', phpunit: 9}
-          - {laravel: 9, php: '8.3', phpunit: 9}
+          - {laravel: 10, php: '8.4'}
     steps:
       - name: Checkout repository
         uses: actions/checkout@v3

composer.json

@@ -12,11 +12,11 @@
     "require": {
         "php": "^8.0",
         "rdx/laravelcollective-html": "^6",
-        "illuminate/database": "^6 || ^7 || ^8 || ^9 || ^10 || ^11",
-        "illuminate/validation": "^6 || ^7 || ^8 || ^9 || ^10 || ^11"
+        "illuminate/database": "^10 || ^11",
+        "illuminate/validation": "^10 || ^11"
     },
     "require-dev": {
-        "orchestra/testbench": "^6.13 || ^7 || ^8 || ^9",
+        "orchestra/testbench": "^8 || ^9",
         "phpunit/phpunit": "^10.0"
     },
     "extra": {

phpunit.xml

@@ -8,7 +8,7 @@
     processIsolation="false"
     stopOnFailure="false"
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd"
+    xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.5/phpunit.xsd"
 >
     <testsuites>
         <testsuite name="Package Test Suite">
@@ -19,7 +19,7 @@
             <exclude>./tests/FormBuilderTestCase.php</exclude>
         </testsuite>
     </testsuites>
-    <coverage>
+    <source>
         <include>
             <directory>./src/Kris</directory>
         </include>
@@ -29,5 +29,5 @@
             <file>./src/Kris/LaravelFormBuilder/Console/FormMakeCommand.php</file>
             <file>./src/Kris/LaravelFormBuilder/FormBuilderTrait.php</file>
         </exclude>
-    </coverage>
+    </source>
 </phpunit>

src/Kris/LaravelFormBuilder/Filters/Exception/InvalidInstanceException.php

@@ -13,9 +13,9 @@
  */
 class InvalidInstanceException extends \Exception
 {
-    public function __construct($message = "", $code = 0, Throwable $previous = null)
+    public function __construct($message = "", $code = 0, ?Throwable $previous = null)
     {
         $message = 'Filter object must implement ' . FilterInterface::class;
         parent::__construct($message, $code, $previous);
     }
-}
+}

src/Kris/LaravelFormBuilder/Filters/Exception/UnableToResolveFilterException.php

@@ -12,9 +12,9 @@
  */
 class UnableToResolveFilterException extends \Exception
 {
-    public function __construct($message = "", $code = 0, Throwable $previous = null)
+    public function __construct($message = "", $code = 0, ?Throwable $previous = null)
     {
         $message = "Passed filter can't be resolved.";
         parent::__construct($message, $code, $previous);
     }
-}
+}

src/Kris/LaravelFormBuilder/RulesParser.php

@@ -606,7 +606,7 @@ protected function parseParameters($rule, $parameter)
         if (strtolower($rule) == 'regex') {
             return [$parameter];
         }
-        return str_getcsv($parameter);
+        return str_getcsv($parameter, escape: '\\');
     }
 
     /**