Adds support for basic s3 url redirects #952
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding url redirect rules to the linked-storage.json meta item causes those redirect rules to be honoured when fetching tiles for any commit that includes the new linked-storage.json. However, this won't help when fetching tiles for older commits which were created before the redirect rules were added. The fix will be to add logic such that Kart finds redirect rules from a newer commit even when fetching tiles when checking out an older commit. TODO: add logic such that Kart finds redirect rules from newer commits. TODO: add a command for setting up redirect rules - right now there is just `kart meta set` which is pretty bare bones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding url redirect rules to the linked-storage.json meta item causes those redirect rules to be honoured when fetching tiles for any commit that includes the new linked-storage.json.
However, this won't help when fetching tiles for older commits which were created before the redirect rules were added. The fix will be to add logic such that Kart finds redirect rules from a newer commit even when fetching tiles when checking out an older commit.
TODO in later PRs:
TODO: add logic such that Kart finds redirect rules from newer commits.
TODO: add a command for setting up redirect rules - right now there is just
kart meta setwhich is pretty bare bones.Related links:
#905
Checklist: