feature: accept_file/reject_file on the same file multiple times per client_id

[djzager]

With the editor-extensions agent mode turned on, when a user requests a fix, the first solution that will be computed is for the particular incidents in a specific file. Once that work is done, knock on tasks are added to the agent's queue (like linting issues or analysis issues created by the given solution).

To accomodate this, we need:

• To potentially call accept_file/reject file multiple times on a particular file for a specific client_id.
• An endpoint so that the IDE can let the solution server know when it is actually done computing solutions.

[JonahSussman]

Here are my thoughts on this. Our current workflow is this:

• Make the solution server aware of a bunch of incidents via create_incident
• Create potential solutions, which contain the changes to each file, that solve a subset of those incidents via create_solution
• Accept, modify, or reject individual files (due to the way we have the IDE flow) via accept_file or reject_file
• Once all files associated with a solution are accepted or rejected, we mark the final status of the solution as ACCEPTED, MODIFIED, etc... and generate hints automatically

I see the logic behind wanting to have multiple "accept"s and "reject"s, but I think keeping that as a one-time thing where the user says "yes this is the final file" is very valuable.

Instead, what about making the solution server aware of the "incidents" that the agent is trying to solve via create_incident and keeping the accept/reject a one-time thing? We would have to modify the parameters and data types to this call, but this gives us the added benefit of now tracking the agent's trajectory and gives us more data for hint generation.

[djzager]

cc @pranavgaikwad and @ibolton336

[pranavgaikwad]

Accept / reject only once per file wouldn't work because the agent is iterative in that it will modify the same file multiple times as different issues are reported every time the file changes. For each write operation, we want to ask the user whether to accept or reject.