Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary directory and windows service checkups need to account for identifier #2023

Open
RebeccaMahany opened this issue Jan 2, 2025 · 0 comments
Labels
bug-fixes Bug Fixes

Comments

@RebeccaMahany
Copy link
Contributor

RebeccaMahany commented Jan 2, 2025

We now pull the incorrect directory in the binary directory checkup if the identifier isn't the default kolide-k2. We should update this checkup to a) call launcher.DefaultPath(launcher.BinDirectory) to get the bin directory, and b) to replace the identifier in the bin directory with the non-default identifier if it's set. (We can do something similar to what the launcher flags checkup does.)

We should additionally update the windows services checkup to incorporate the identifier with the service name here. there is a utility function here that will generate the correct service name for querying. this will ensure that the correct event logs are collected

@RebeccaMahany RebeccaMahany added the bug-fixes Bug Fixes label Jan 2, 2025
@zackattack01 zackattack01 changed the title Binary directory checkup needs to account for identifier Binary directory and windows service checkups need to account for identifier Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fixes Bug Fixes
Projects
None yet
Development

No branches or pull requests

1 participant