Repository navigation
fix: accept either quote style for the node version in action.yml - #106
Merged
Merged
Conversation
- Match both 'nodeXX' and "nodeXX" in build.mjs - Drop the YAML quoteStyle override and use Biome's default double quotes - Reformat YAML files with double quotes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #104. Switches YAML formatting to Biome's default double quotes.
Changes
build.mjsnow matches the node version inaction.ymlwith either quote style (/using:\s*(['"])node(\d+)\1/). It previously requiredusing: 'nodeXX', so double-quotingaction.ymlmadenpm run packagefail withCould not find node version in action.yml.yaml.formatter.quoteStyle: "single"override frombiome.json. YAML now uses Biome's default double quotes, the same asjavascript.formatter.quoteStyleand JSON.action.yml, workflows, and YAML examples inREADME.mdwith double quotes..github/dependabot.ymlreturns to its original double quotes.Verification
npm run lintpasses.npx vitest run --coverage: 292 tests pass, coverage 100%.npm run packagesucceeds with nodist/diff (esbuild target staysnode24).🤖 Generated with Claude Code