Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First filter(), second rules() #111

Open
ghost opened this issue Feb 3, 2015 · 2 comments
Open

First filter(), second rules() #111

ghost opened this issue Feb 3, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Feb 3, 2015

By this (title of issue), password of user first hashes (By filter of Model_User (Auth::instance()->hash()), and after them it checks for some rules from rules() method. And, so, min_length, for example, doesn't works.

@dejwid
Copy link

dejwid commented Mar 19, 2015

Rules should be checked just before inserting data to database, because:
For example: What if string will be longer then your database column expect? - Error.
So, I think that you have check password length before putting into model. You should validate password in controller.
Summary: Everythink works good but just not like author expected. This issue should be marked as closed.

@ghost
Copy link
Author

ghost commented Mar 19, 2015

@dejwid, Did you read my question? So, test them and see. That a bug of rules()/filters(), which should be fixed.

Also, you can search this trouble in internet, i am not only in catching this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant