fix(bookmarks): anonymize doubts through toPublicDoubt - #1297
Conversation
|
@Kirtan-pc is attempting to deploy a commit to the Karan Mani Tripathi 's projects Team on Vercel. A member of the Team first needs to authorize it. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Warning Review limit reached
Next review available in: 49 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches 💡 2⚔️ Resolve merge conflicts 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| return NextResponse.json({ | ||
| data: doubts, | ||
| data: publicDoubts, |
There was a problem hiding this comment.
Suggestion: The response is now wrapped in an object containing data and pagination, but the bookmarks page assigns the entire JSON response to state and immediately calls bookmarks.filter(...). This makes the page throw at runtime because the stored value is an object rather than an array. Either preserve the previous array response contract or update the client to consume data.publicDoubts/data as appropriate. [api mismatch]
Severity Level: Major ⚠️
- ❌ Bookmarks page crashes after successful API responses.
- ❌ Users cannot view or search saved doubts.
- ⚠️ Retry requests reproduce the same client-side failure.(Use Cmd/Ctrl + Click for best experience)
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/app/api/bookmarks/route.ts
**Line:** 99:100
**Comment:**
*Api Mismatch: The response is now wrapped in an object containing `data` and `pagination`, but the bookmarks page assigns the entire JSON response to state and immediately calls `bookmarks.filter(...)`. This makes the page throw at runtime because the stored value is an object rather than an array. Either preserve the previous array response contract or update the client to consume `data.publicDoubts`/`data` as appropriate.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
knoxiboy
left a comment
There was a problem hiding this comment.
Hi @Kirtan-pc! Thanks for routing doubt bookmarks through oPublicDoubt (#1101).
Stripping author details on anonymous bookmarked doubts is an important privacy fix. Before merging:
- Unit Test Coverage: Please add a test case in src/tests/api/bookmarks.test.ts verifying that fetching bookmarked doubts strips user email and author fields when isAnonymous is rue.
Thanks for your work!
…l fields for anonymous doubts
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Hey @knoxiboy, |
User description
Description
Fixes a privacy leak in
GET /api/bookmarks. The route was serializing rawdoubtsTablerecords (via a plain...doubtspread), exposing each bookmarked doubt's authoruserEmail, the internalembeddingpgvector, anddeletedAtto authenticated clients, bypassing the anonymity system entirely. Bookmarked doubts are now passed throughtoPublicDoubt(doubt, email)— the same chokepoint used byGET /api/doubts,GET /api/doubts/[id], and the classroomexport route — so responses only expose the anonymizedauthorhandle,authorInitial, andisOwnPostflag, while preservinghasLiked,hasBookmarked, andreplyCount.Related Issue
Closes #1101
Type of Change
How Has This Been Tested?
npm run devChecklist
npm run dev)anytypes)mainCodeAnt-AI Description
Protect author privacy in bookmarked doubts
What Changed
Impact
✅ No author email leaks from bookmarked doubts✅ Consistent anonymous author display✅ Preserved likes, bookmarks, and reply counts💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.