fix: Windows-compatible path handling in JS/Go parsers (#46)

Author: joshbouncesecurity

libs/openant-core/parsers/go/test_pipeline.py

@@ -44,6 +44,31 @@
 from typing import Set
 from utilities.file_io import open_utf8, read_json, run_utf8, write_json
 
+
+def _stdout_supports_unicode() -> bool:
+    """Return True if sys.stdout can emit the symbols we use for status.
+
+    Returns False when stdout is piped or redirected (common in CI) and
+    the encoding cannot be determined — this degrades output to plain ASCII
+    rather than raising UnicodeEncodeError at runtime.
+    """
+    encoding = getattr(sys.stdout, "encoding", None)
+    if not encoding:
+        return False
+    try:
+        # Probe with the actual symbols we emit. This catches cp1252 and
+        # other limited code pages without us having to enumerate them.
+        "✓✗→".encode(encoding)
+        return True
+    except (UnicodeEncodeError, LookupError):
+        return False
+
+
+_UNICODE_OK = _stdout_supports_unicode()
+SYM_OK = "✓" if _UNICODE_OK else "OK"
+SYM_FAIL = "✗" if _UNICODE_OK else "FAIL"
+SYM_ARROW = "→" if _UNICODE_OK else "->"
+
 # Add parent directory to path for utilities import
 sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.dirname(os.path.abspath(__file__)))))
 from utilities.context_enhancer import ContextEnhancer
@@ -159,7 +184,7 @@ def run_stage(self, name: str, command: list, output_file: str) -> dict:
             }
 
             if result.returncode == 0:
-                print(f"✓ Success ({elapsed:.2f}s)")
+                print(f"{SYM_OK} Success ({elapsed:.2f}s)")
                 print()
                 # Print stderr (often contains summary info)
                 if result.stderr:
@@ -172,7 +197,7 @@ def run_stage(self, name: str, command: list, output_file: str) -> dict:
                     data = read_json(output_file)
                     stage_result['summary'] = self._summarize_output(name, data)
             else:
-                print(f"✗ Failed (exit code {result.returncode})")
+                print(f"{SYM_FAIL} Failed (exit code {result.returncode})")
                 print()
                 if result.stderr:
                     print("STDERR:")
@@ -185,7 +210,7 @@ def run_stage(self, name: str, command: list, output_file: str) -> dict:
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             return {
                 'success': False,
                 'elapsed_seconds': elapsed,
@@ -373,17 +398,17 @@ def apply_reachability_filter(self) -> bool:
                 'summary': summary
             }
 
-            print(f"✓ Success ({elapsed:.2f}s)")
+            print(f"{SYM_OK} Success ({elapsed:.2f}s)")
             print(f"  Entry points detected: {len(self.entry_points)}")
-            print(f"  Units: {original_count} → {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
+            print(f"  Units: {original_count} {SYM_ARROW} {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
             print()
 
             self.results['stages']['reachability_filter'] = result
             return True
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             import traceback
             traceback.print_exc()
             result = {
@@ -437,7 +462,7 @@ def run_codeql_analysis(self) -> bool:
             )
 
             if result.returncode != 0:
-                print(f"✗ CodeQL database creation failed")
+                print(f"{SYM_FAIL} CodeQL database creation failed")
                 print(f"  stderr: {result.stderr[:500] if result.stderr else 'none'}")
                 elapsed = (datetime.now() - start_time).total_seconds()
                 self.results['stages']['codeql_analysis'] = {
@@ -468,7 +493,7 @@ def run_codeql_analysis(self) -> bool:
             )
 
             if result.returncode != 0:
-                print(f"✗ CodeQL analysis failed")
+                print(f"{SYM_FAIL} CodeQL analysis failed")
                 print(f"  stderr: {result.stderr[:500] if result.stderr else 'none'}")
                 elapsed = (datetime.now() - start_time).total_seconds()
                 self.results['stages']['codeql_analysis'] = {
@@ -484,7 +509,7 @@ def run_codeql_analysis(self) -> bool:
             # Step 3: Parse SARIF output
             print("Parsing results...")
             if not os.path.exists(sarif_output):
-                print("✗ SARIF output not found")
+                print(f"{SYM_FAIL} SARIF output not found")
                 elapsed = (datetime.now() - start_time).total_seconds()
                 self.results['stages']['codeql_analysis'] = {
                     'success': False,
@@ -544,7 +569,7 @@ def run_codeql_analysis(self) -> bool:
                 'summary': summary
             }
 
-            print(f"✓ Success ({elapsed:.2f}s)")
+            print(f"{SYM_OK} Success ({elapsed:.2f}s)")
             print(f"  Total findings: {len(self.codeql_findings)}")
             print(f"  Unique files: {summary['unique_files']}")
             if summary['by_level']:
@@ -556,7 +581,7 @@ def run_codeql_analysis(self) -> bool:
 
         except FileNotFoundError:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print("✗ CodeQL not found. Please install CodeQL CLI.")
+            print(f"{SYM_FAIL} CodeQL not found. Please install CodeQL CLI.")
             print("  See: https://docs.github.com/en/code-security/codeql-cli")
             self.results['stages']['codeql_analysis'] = {
                 'success': False,
@@ -567,7 +592,7 @@ def run_codeql_analysis(self) -> bool:
 
         except subprocess.TimeoutExpired:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print("✗ CodeQL analysis timed out")
+            print(f"{SYM_FAIL} CodeQL analysis timed out")
             self.results['stages']['codeql_analysis'] = {
                 'success': False,
                 'elapsed_seconds': elapsed,
@@ -577,7 +602,7 @@ def run_codeql_analysis(self) -> bool:
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             import traceback
             traceback.print_exc()
             self.results['stages']['codeql_analysis'] = {
@@ -687,18 +712,18 @@ def apply_codeql_filter(self) -> bool:
                 'summary': summary
             }
 
-            print(f"✓ Success ({elapsed:.2f}s)")
+            print(f"{SYM_OK} Success ({elapsed:.2f}s)")
             print(f"  CodeQL findings: {len(self.codeql_findings)}")
             print(f"  Flagged function units: {len(self.codeql_flagged_units)}")
-            print(f"  Units: {original_count} → {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
+            print(f"  Units: {original_count} {SYM_ARROW} {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
             print()
 
             self.results['stages']['codeql_filter'] = result
             return True
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             import traceback
             traceback.print_exc()
             result = {
@@ -774,14 +799,14 @@ def run_context_enhancer(self) -> bool:
             }
 
             print()
-            print(f"✓ Success ({elapsed:.2f}s)")
+            print(f"{SYM_OK} Success ({elapsed:.2f}s)")
 
             self.results['stages']['context_enhancer'] = result
             return True
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             import traceback
             traceback.print_exc()
             result = {
@@ -861,20 +886,20 @@ def apply_exploitable_filter(self) -> bool:
                 'summary': summary
             }
 
-            print(f"✓ Success ({elapsed:.2f}s)")
+            print(f"{SYM_OK} Success ({elapsed:.2f}s)")
             print(f"  Classification breakdown:")
             for cls, count in sorted(classification_counts.items()):
-                marker = "→" if cls == "exploitable" else " "
+                marker = SYM_ARROW if cls == "exploitable" else " "
                 print(f"    {marker} {cls}: {count}")
-            print(f"  Units: {original_count} → {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
+            print(f"  Units: {original_count} {SYM_ARROW} {len(filtered_units)} ({summary['reduction_percentage']}% reduction)")
             print()
 
             self.results['stages']['exploitable_filter'] = result
             return True
 
         except Exception as e:
             elapsed = (datetime.now() - start_time).total_seconds()
-            print(f"✗ Error: {e}")
+            print(f"{SYM_FAIL} Error: {e}")
             import traceback
             traceback.print_exc()
             result = {
@@ -954,13 +979,13 @@ def run_full_pipeline(self):
         self.results['success'] = all_success
 
         if all_success:
-            print("✓ All stages completed successfully")
+            print(f"{SYM_OK} All stages completed successfully")
         else:
-            print("✗ Some stages failed")
+            print(f"{SYM_FAIL} Some stages failed")
 
         print()
         for stage_name, stage_result in self.results['stages'].items():
-            status = "✓" if stage_result.get('success') else "✗"
+            status = SYM_OK if stage_result.get('success') else SYM_FAIL
             elapsed = stage_result.get('elapsed_seconds', 0)
             print(f"  {status} {stage_name}: {elapsed:.2f}s")
 

libs/openant-core/parsers/javascript/path_utils.js

@@ -0,0 +1,28 @@
+"use strict";
+
+/**
+ * Convert a filesystem path to forward slashes.
+ *
+ * ts-morph stores source-file paths internally with forward slashes and
+ * also treats backslashes as escape characters when matching paths it
+ * has already added. On Windows, Node's `path.relative()` and
+ * `path.resolve()` return backslash-separated paths, which causes
+ * ts-morph to silently fail to find any files (resulting in 0 functions
+ * extracted). Always normalise to forward slashes before handing paths
+ * to ts-morph or storing them as functionId components.
+ *
+ * UNC paths (`\\server\share\...`) are correctly converted to
+ * `//server/share/...`, which TypeScript understands on Windows.
+ *
+ * CONTRACT FOR CONTRIBUTORS: every path that will be passed to ts-morph
+ * (addSourceFileAtPath, getSourceFile, etc.) or stored as a functionId
+ * component MUST go through toPosixPath() first. This applies to the
+ * result of any path.resolve(), path.relative(), or path.join() call.
+ * Skipping this step silently breaks Windows: ts-morph finds zero files
+ * and the analyzer emits an empty result without an error.
+ */
+function toPosixPath(p) {
+  return p.replace(/\\/g, "/");
+}
+
+module.exports = { toPosixPath };