Skip to content

Commit 3884dd2

Browse files
committed
HUB-8726: handle packages without repository or license text
HUB-8726 (Open-source-credits page does not show packages)
1 parent eb2631e commit 3884dd2

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

.changeset/shiny-olives-pull.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@knime/licenses": patch
3+
---
4+
5+
handle packages without repository or license text

packages/licenses/src/collect-packages.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,9 @@ const checkLicenses = (knimePackages) => {
9696

9797
// keep only the needed props
9898
allPackages = allPackages.map((pkg) => ({
99-
// TODO: WEBP-243 handle licenses with missing text or similar licenses
10099
name: pkg.name,
101-
repository: pkg.repository,
102-
licenseText: pkg.licenseText,
100+
repository: pkg.repository ?? "",
101+
licenseText: pkg.licenseText ?? "",
103102
}));
104103

105104
let allUniquePackages = [];

0 commit comments

Comments
 (0)