Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep the ReplicaSets to a minimum for knative-serving deployments. #15639

Open
subhasree91 opened this issue Nov 29, 2024 · 0 comments
Open

Keep the ReplicaSets to a minimum for knative-serving deployments. #15639

subhasree91 opened this issue Nov 29, 2024 · 0 comments
Labels
kind/feature Well-understood/specified features, ready for coding.

Comments

@subhasree91
Copy link

Currently, by default the deployments in k8s have .spec.revisionHistoryLimit set to 10. This means that k8s will keep the latest 10 replicasets for an deployment.

If the number of replicasets can be set to minimum (eg: 2 or less) that will help reduce the load on etcd.

In the reconcileDeployment function, the logic to set the default revisionHistoryLimit can be added as part of this controller.
@subhasree91 subhasree91 added the kind/feature Well-understood/specified features, ready for coding. label Nov 29, 2024
@subhasree91 subhasree91 mentioned this issue Nov 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Well-understood/specified features, ready for coding.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keep the number of ReplicaSets to a minimum subhasree91/serving
1 participant
@subhasree91