Skip to content

Commit 6a7f532

Browse files
authored
Use constant format string in MarkReadyFalse (#1021)
go vet's printf check flags the message passed as a format string to ConditionManager.MarkFalse. A message holding '%' would also be garbled. This blocks the dependency update to go 1.26 / k8s 0.36 (#1019).
1 parent f75d9de commit 6a7f532

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎pkg/apis/caching/v1alpha1/image_lifecycle.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,5 +71,5 @@ func (is *ImageStatus) MarkReadyTrue() {
7171

7272
// MarkImageFailed marks the "ImageConditionReady" condition to false.
7373
func (is *ImageStatus) MarkReadyFalse(reason, message string) {
74-
condSet.Manage(is).MarkFalse(ImageConditionReady, reason, message)
74+
condSet.Manage(is).MarkFalse(ImageConditionReady, reason, "%s", message)
7575
}

0 commit comments

Comments
 (0)