Skip to content

Conversation

@knative-automation
Copy link
Contributor

Cron -dprotaso

/cc knative-extensions/serving-writers
/assign knative-extensions/serving-writers

Produced by: knative-extensions/knobots/actions/update-deps

bumping k8s.io/gengo/v2 1244d31...85fd79d:
  > 85fd79d Merge pull request # 304 from jpbetz/full-parser
  > b22feca Merge pull request # 306 from carsontham/support-omitzero-in-LookupJSON
  > b37a58d Add utility functions to access args
  > cc0d9c4 Add named arg parser (# 299)
  > c990d91 added support for omitzero
  > db65aa6 Apply feedback
  > 3d52566 Merge pull request # 303 from thockin/master
  > 1460848 Switch to # for comments
  > 5d81b21 Merge pull request # 297 from jpbetz/tag-parser
  > ea49fb3 Treat embedded fields as inline
  > 44a1af5 Limit whitespace to after : and , for named args
  > 221fad0 Merge pull request # 296 from aaron-prindle/rawstring-tag-parsing
  > ae132b4 Apply feedback
  > dcc70af Simplify whitespace handling and collapse needless states
  > e3bc6f1 Merge pull request # 293 from shashankram/fix-ignore
  > fc15268 feat: add raw string support to gengo comment tag arg parsing
  > 5502674 Add JSON tag argument support
  > 53609f6 Rename TypedTag to Tag
  > 83e62b2 parser/test: fix bug in comparison
  > 271cbf8 Apply feedback
  > c926ad7 Add missing break
  > c375a88 Add dedicated scanner tests
  > 7d6753c Add godoc to TypeTag.String(), add a 4 level nesting test
  > 4842742 Add a simple scanner and move literal value parsing into micro-FSMs.
  > 461f54c Test parse string for extract, fix incomplete value bug
  > 2f7fe8a Add opt-in support for value parsing to ExtractFunctionStyleCommentTags and ExtractSingleBoolCommentTag
  > e0a2d5e Expand and clean up tests
  > 88534e7 Add chained tag parsing

Signed-off-by: Knative Automation <[email protected]>
@knative-prow knative-prow bot requested a review from a team November 10, 2025 02:08
@knative-prow
Copy link

knative-prow bot commented Nov 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: knative-automation
Once this PR has been reviewed and has the lgtm label, please assign gauron99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 10, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 10, 2025

@knative-automation: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
unit-tests_net-gateway-api_main 371f0ab link true /test unit-tests
build-tests_net-gateway-api_main 371f0ab link true /test build-tests
integration-tests-contour_net-gateway-api_main 371f0ab link true /test integration-tests-contour
integration-tests-istio_net-gateway-api_main 371f0ab link true /test integration-tests-istio

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. skip-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant