Repository navigation
fixes/ST1001-linter #9720
Cali0707knative-style.yaml
on: pull_request
style
/
changes
3s
style
/
...
/
Auto-format and Check
26s
style
/
...
/
Lint
3m 21s
style
/
...
/
Do Not Submit
7s
style
/
...
/
shell
style
/
...
/
yaml
25s
style
/
...
/
github_actions
Matrix: style / Golang / Boilerplate Check
Annotations
12 errors and 4 warnings
|
style / Golang / Auto-format and Check
Process completed with exit code 1.
|
|
style / Golang / Auto-format and Check:
test/rekt/features/kafka_source.go#L0
Please run goimports.
diff --git a/test/rekt/features/kafka_source.go b/test/rekt/features/kafka_source.go
index dadd99a..012e9d9 100644
--- a/test/rekt/features/kafka_source.go
+++ b/test/rekt/features/kafka_source.go
@@ -70,8 +70,6 @@ const (
PlainMech = "plain"
)
-
-
func SetupAndCleanupKafkaSources(prefix string, n int) *feature.Feature {
f := SetupKafkaSources(prefix, n)
f.Teardown("cleanup resources", f.DeleteResources)
|
|
style / Golang / Auto-format and Check:
test/e2e_source/helpers/kafka_source.go#L0
Please run goimports.
diff --git a/test/e2e_source/helpers/kafka_source.go b/test/e2e_source/helpers/kafka_source.go
index 3a74cb5..1234e12 100644
--- a/test/e2e_source/helpers/kafka_source.go
+++ b/test/e2e_source/helpers/kafka_source.go
@@ -225,4 +225,4 @@ func testKafkaSource(t *testing.T,
Group: consumerGroup,
}, expectedLag)
require.Nil(t, err, "Failed to verify committed offset")
-}
\ No newline at end of file
+}
|
|
style / Golang / Auto-format and Check:
control-plane/pkg/reconciler/testing/factory.go#L0
Please run goimports.
diff --git a/control-plane/pkg/reconciler/testing/factory.go b/control-plane/pkg/reconciler/testing/factory.go
index 467ea33..4baf316 100644
--- a/control-plane/pkg/reconciler/testing/factory.go
+++ b/control-plane/pkg/reconciler/testing/factory.go
@@ -54,7 +54,7 @@ type Ctor func(ctx context.Context, listers *Listers, env *config.Env, row *rtes
func NewFactory(env *config.Env, ctor Ctor) rtesting.Factory {
return func(t *testing.T, row *rtesting.TableRow) (pkgcontroller.Reconciler, rtesting.ActionRecorderList, rtesting.EventList) {
- listers := newListers(row.Objects)
+ listers := newListers(row.Objects)
var ctx context.Context
if row.Ctx != nil {
ctx = row.Ctx
|
|
style / Golang / Auto-format and Check:
control-plane/pkg/reconciler/consumergroup/consumergroup.go#L0
Please run goimports.
diff --git a/control-plane/pkg/reconciler/consumergroup/consumergroup.go b/control-plane/pkg/reconciler/consumergroup/consumergroup.go
index 8ae5fa6..8a2637a 100644
--- a/control-plane/pkg/reconciler/consumergroup/consumergroup.go
+++ b/control-plane/pkg/reconciler/consumergroup/consumergroup.go
@@ -812,7 +812,7 @@ func getMetricAttributes(cg *kafkainternals.ConsumerGroup) []attribute.KeyValue
if uf == nil {
return []attribute.KeyValue{}
}
-
+
switch strings.ToLower(uf.Kind) {
case "trigger":
return []attribute.KeyValue{TriggerNameKey.With(uf.Name), TriggerNamespaceKey.With(cg.Namespace)}
|
|
style / Golang / Lint
Process completed with exit code 1.
|
|
style / Golang / Lint:
test/e2e_source/helpers/kafka_source.go#L228
[EOF Newline] reported by reviewdog 🐶
Missing newline
Raw Output:
test/e2e_source/helpers/kafka_source.go:228: Missing newline
|
|
style / Golang / Lint
Process completed with exit code 1.
|
|
style / Golang / Lint:
.golangci.yaml#L25
[trailing whitespace] reported by reviewdog 🐶
Raw Output:
.golangci.yaml:25:
|
|
style / Golang / Lint
issues found
|
|
style / Golang / Lint:
test/e2e_sink/kafka_sink.go#L44
undefined: testpkgtesting.RunMultiple (typecheck)
|
|
style / Golang / Lint:
test/e2e_sink/kafka_sink.go#L43
undefined: testpkg.SecretProvider
|
|
style / Golang / Boilerplate Check (go)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
|
style / Golang / Boilerplate Check (sh)
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
|
style / Golang / Auto-format and Check
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|
|
style / Golang / Lint
Restore cache failed: Dependencies file is not found in /home/runner/work/eventing-kafka-broker/eventing-kafka-broker. Supported file pattern: go.sum
|