fix: clean up redundant cloning

klocke-io · klocke-io · commit 24f435af82de · 2026-03-02T15:33:26.000+01:00
diff --git a/backend/lib/cache/index.js b/backend/lib/cache/index.js
@@ -78,7 +78,6 @@ export default {
     return _
       .chain(cache.getCloudProfiles())
       .find(['metadata.name', name])
-      .cloneDeep()
       .value()
   },
   getNamespacedCloudProfiles (namespace) {
diff --git a/backend/lib/services/namespacedCloudProfiles.js b/backend/lib/services/namespacedCloudProfiles.js
@@ -29,12 +29,11 @@ function computeDiff (namespacedCloudProfile) {
     return null
   }
 
-  // Simplify both profiles to ensure consistent providerConfig filtering
-  const simplifiedParent = simplifyCloudProfile(_.cloneDeep(parentCloudProfile))
-  const simplifiedNamespaced = _.cloneDeep(namespacedCloudProfile)
+  // parentCloudProfile is already cloned by cache.getCloudProfile(name)
+  const simplifiedParent = simplifyCloudProfile(parentCloudProfile)
 
   const parentSpec = _.get(simplifiedParent, ['spec'], {})
-  const namespacedSpec = _.get(simplifiedNamespaced, ['status', 'cloudProfileSpec'], {})
+  const namespacedSpec = _.get(namespacedCloudProfile, ['status', 'cloudProfileSpec'], {})
 
   return jsondiffpatch.diff(parentSpec, namespacedSpec)
 }

Original file line number	Diff line number	Diff line change
`@@ -29,12 +29,11 @@ function computeDiff (namespacedCloudProfile) {`
`29`	`29`	`return null`
`30`	`30`	`}`
`31`	`31`
`32`		`- // Simplify both profiles to ensure consistent providerConfig filtering`
`33`		`- const simplifiedParent = simplifyCloudProfile(_.cloneDeep(parentCloudProfile))`
`34`		`- const simplifiedNamespaced = _.cloneDeep(namespacedCloudProfile)`
	`32`	`+ // parentCloudProfile is already cloned by cache.getCloudProfile(name)`
	`33`	`+ const simplifiedParent = simplifyCloudProfile(parentCloudProfile)`
`35`	`34`
`36`	`35`	`const parentSpec = _.get(simplifiedParent, ['spec'], {})`
`37`		`- const namespacedSpec = _.get(simplifiedNamespaced, ['status', 'cloudProfileSpec'], {})`
	`36`	`+ const namespacedSpec = _.get(namespacedCloudProfile, ['status', 'cloudProfileSpec'], {})`
`38`	`37`
`39`	`38`	`return jsondiffpatch.diff(parentSpec, namespacedSpec)`
`40`	`39`	`}`