Support Leaflet 1.0

[kklimczak]

No description provided.

[grundid]

Hi. I find your project very interesting and would like to contribute. I see you already have leaflet 1.0.1 as dependency in your bower file.
Is this ticket still an issue? What problems do you see with leaflet 1.0?

[kklimczak]

Hi
I bumped leaflet version to 1.0.1 and forgot close issue.
Nevertheless I think that plugin need to rewrite some methods (i.e. pin to circle) because new version of leaflet add extra API features doesn't available when I was writing leaflet.pin.

So if you have some idea connected with plugin, feel free to make pull request. ;)

[grundid]

Thanks. Right now I've updated all deps to the latests versions.
The main issue seams to be due to a breaking change in beta 1: https://github.com/Leaflet/Leaflet/blob/master/CHANGELOG.md#10-beta1-july-14-2015

getLatLngs now returns an array of nested rings instead of an array of points. This does not work with the "closest" method from the geometryUtils lib.
Since your Pin plugin uses only one method (closestLayerSnap) from the GeometryUtils lib maybe I can fix it myself ;)

[kklimczak]

I didn't read this changelog so if you can fix it, I don't see why not. ;)

I'd like to improve pin to circle, because it's a my proof of concept and at this moment work but not very well.

[grundid]

hi. I just wanted to note that I switched my focus to mapbox-gl draw tool. Here is also some progress on snap functions.
mapbox/mapbox-gl-draw#583

[tmh12345]

May I know this plugin support the latest version of leaflet.draw version 1.0.2 and leaflet.js 1.3.1?

[kklimczak]

At this moment, I don't know. The last changes to this project I has been made 2 years ago. In the future I will make support for leaflet 1+ but now I don't have enough time to do this.

[tmh12345]

Thank you a lot. Wish you make it support.

[overly-engineered]

Hi @kklimczak just started using your project. I've got a fix for some of the issues with leaflet 1, and also for the layer pinning to themselves bughttps://github.com/kklimczak/Leaflet.Pin/blob/master/src/leaflet.pin.js#L185

Can i create pull requests for them?

[kklimczak]

Go ahead :)