Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiling in release in the CI should be piloted from the CI #803

Open
mgautierfr opened this issue Jan 9, 2025 · 2 comments
Open

Compiling in release in the CI should be piloted from the CI #803

mgautierfr opened this issue Jan 9, 2025 · 2 comments
Labels
bug CI compilation question

Comments

@mgautierfr
Copy link
Member

The PR #779 remove any possibilities to compile in debug on Windows from kiwix-build (which is kind of the only way to compile everything "easily" at all).

Building in release should be piloted by an option given in the CI. We should not make kiwix-build always compiling in release.
@kelson42
Copy link
Contributor

kelson42 commented Jan 9, 2025 •
edited
Loading

Neither the CI nor the CD compile anymore in debug on Windows on purpose. Why should we keep this ability in kiwix-build?

@mgautierfr
Copy link
Member Author

For debug purpose. Developer may (and I am) use kiwix-build to compile kiwix-desktop on Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug CI compilation question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mgautierfr @kelson42