Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Wikipedia Links #731

Open
TimMagee opened this issue May 14, 2018 · 16 comments · May be fixed by #3864
Open

Open Wikipedia Links #731

TimMagee opened this issue May 14, 2018 · 16 comments · May be fixed by #3864

Comments

@TimMagee
Copy link

Could Kiwix Android open wikipedia.org links?

Or would this be too difficult?

@mhutti1
Copy link
Contributor

mhutti1 commented May 14, 2018

I did do some preliminary research into this and as far as I am aware to open domain links like that requires control over domain you are accessing.

@TimMagee
Copy link
Author

Hmmm . . . .
All the unofficial Reddit apps can open Reddit links.
NewPipe can open Youtube links.
Twidiere can open Twitter links.
I don't think we need to control wikipedia.org to register as an opener for wikipedia.org links.
Remember, we are simply registering our app withing the android system.

@siddharthks2010
Copy link

siddharthks2010 commented May 18, 2018

@TimMagee @mhutti1 , Actually, it just requires an intent filter.

screenshot_20180518-075048

You just need to add the following code in the android manifest:

<intent-filter>
  <action android:name="android.intent.action.VIEW" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
  <data android:host="www.wikipedia.com" android:scheme="http" />
</intent-filter>

@mhutti1
Copy link
Contributor

mhutti1 commented May 18, 2018

Oh ok. I equated offline search with linking for some reason. Is there a way to programmically add hosts though?

@siddharthks2010
Copy link

siddharthks2010 commented May 19, 2018

@mhutti1 I am not quite sure I understand. By "programmically adding hosts", do you mean that we add a set of hosts in a resource file and run a loop in the android manifest, and reference a host from the file in each iteration to make the intent filter?

@mhutti1
Copy link
Contributor

mhutti1 commented May 20, 2018

Yes something like that.

@siddharthks2010
Copy link

I did some research on this topic, but i couldn't find much. I don't think we can add the loop directly in the xml file. However, we can write a simple python script that takes a resource file containing the hosts and generate the required xml code.

@mhutti1
Copy link
Contributor

mhutti1 commented May 21, 2018

Ok, we can at least add a few different popular ones even if we can't do it programmically.

@kelson42
Copy link
Collaborator

This tickets depends in addition of the implementation of openzim/mwoffliner#278

@mhutti1
Copy link
Contributor

mhutti1 commented Jun 28, 2018

It might be possible to implement this without that fix with a small workaround to edit the URL before passing it.

@stale
Copy link

stale bot commented Jun 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jun 26, 2019
@stale stale bot removed the stale label May 2, 2020
@stale
Copy link

stale bot commented Jul 1, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jul 1, 2020
@TimMagee
Copy link
Author

This issue is still as relevant today as it ever has been.

@stale stale bot removed the stale label Oct 22, 2021
@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@kelson42
Copy link
Collaborator

kelson42 commented Jan 7, 2023

Here one problem is as well that, how to know that Kiwix has actually the ZIM able to provide the specific Wikipedia article provided?

@ThreeDeeJay
Copy link

Any updates on this?

This tickets depends in addition of the implementation of openzim/mwoffliner#278

Looks like it was implemented 👀 openzim/mwoffliner#552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants