Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we pick any ZIM file via file picker then it is not adding into library screen. #3650

Closed
MohitMaliFtechiz opened this issue Jan 3, 2024 · 4 comments · Fixed by #3652
Assignees
Milestone

Comments

@MohitMaliFtechiz
Copy link
Collaborator

MohitMaliFtechiz commented Jan 3, 2024

Describe the bug
If user devices have lots of files in storage, our scanning takes time to list the ZIM file on the library screen. If the user selects the ZIM file via file picker then also it is not showing in the library screen because it does not remember the opened file via file picker (All the other actions are working fine e.g. opening this file from bookmark, history etc).
Only scanning is responsible for showing the ZIM files on the library screen.
A user is experiencing this issue on his device see #3646 for more details.

Expected behavior
If a user selects the ZIM file via file picker it should remember that file and should be listed on the local library screen since our app already knows this file exists in the file system.

Environment

  • Version of Kiwix Android : 3.9.1
  • Device : Any device.
  • OS version : Any android version.
@kelson42
Copy link
Collaborator

kelson42 commented Jan 3, 2024

@MohitMaliFtechiz You misunderstand the problem and makes link between things which are unrelated. If the app knows about a ZIM file (which is the case here because file is open via filepicker) then it has to be remembered in local library.... this whatever the scanning does or doesn't do. This is why this us a bug.

@MohitMaliFtechiz
Copy link
Collaborator Author

If the app knows about a ZIM file (which is the case here because file is open via filepicker) then it has to be remembered in local library.

@kelson42 Thanks for additional clarification, I think the issue description is a little short to explain, I have updated the description.

@kelson42
Copy link
Collaborator

kelson42 commented Jan 3, 2024

@MohitMaliFtechiz Its obvious and is probably already handled, but duplicated entries in local library... in any cases. Shoild be anyway trivial to implement.

@MohitMaliFtechiz
Copy link
Collaborator Author

@kelson42 We have placed a fix for it in #3652. To slow down the scanning progress i have created 20K dummy files in my device, for proper testing of this scenario, everything working fine. I have put a video on the PR description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants