Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tabs & recreation is loading home page on other tabs #2545

Closed
macgills opened this issue Dec 10, 2020 · 3 comments
Closed

New Tabs & recreation is loading home page on other tabs #2545

macgills opened this issue Dec 10, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@macgills
Copy link
Contributor

macgills commented Dec 10, 2020

Describe the bug
Original report:

now I see that also when I create new tabs or minimize, it takes any other tab and takes it to the “Welcome” page. It also takes away their thumbnails.

Expected behavior
A tab should maintain its url

Environment

  • Version of Kiwix Android : 3.4.1
@macgills
Copy link
Contributor Author

I attempted a solution using restoreState saveState so we can maintain the WebBackForwardList across Reader instances but this didn't bear fruit for me. It will however be necessary if we want to allow users to mainatain a tab's navigation stack. The alternative is a database and we entirely ignore the Webview's opinion on whether it can go back or not

@macgills
Copy link
Contributor Author

NB: the currently linked PR does not restore the history of a tab, it just loads the most recent url of a tab, ie pressing back will close reader regardless of how deeply nested the url was in the tab history pre-restoration

macgills added a commit that referenced this issue Dec 15, 2020
…tion

#2545 New Tabs & recreation is loading home page on other tabs
@s-ayush2903
Copy link
Contributor

Mentions #2581(to keep in light not to hamper/modify the article position restoring algorithm) and

the currently linked PR does not restore the history of a tab,

is tracked in #2582.

Closing, as the issue has been fixed by the linked PR(merged) and a good to have feature is now being tracked in the ticket aforementioned(i.e., #2582 )

@s-ayush2903 s-ayush2903 unpinned this issue Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants