Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced vertical resizing #51

Open
kirjs opened this issue Dec 26, 2016 · 3 comments
Open

Advanced vertical resizing #51

kirjs opened this issue Dec 26, 2016 · 3 comments
Assignees

Comments

@kirjs
Copy link
Owner

kirjs commented Dec 26, 2016

I'm pretty happy with the current state of the vertical resizing (adjust to content) except the case when the first file has too many lines.

In that case editing the second file becomes painful.

Solution would be making the first file resizable after certain size?

@UmaMoiseenko
Copy link
Collaborator

I think it makes sense to let user to resize component from the beginning.
Once it's resized smaller than the content of the code editor - it wouldn't grow as user adds lines.
If it's resized to the size that fits all contents of the editor - it grows again as user adds lines. Let me know if that works.

@kirjs
Copy link
Owner Author

kirjs commented Dec 26, 2016

Sounds good for me

@UmaMoiseenko
Copy link
Collaborator

@kirjs since we changed our strategy a little, and now we display one file at a time, it illuminates the need in window size getting bigger as user adds code to the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants