Skip to content
This repository has been archived by the owner on Jun 6, 2023. It is now read-only.

ESLint hook doesn't stop commit on warnings #79

Open
kiriDevs opened this issue Sep 1, 2022 · 0 comments
Open

ESLint hook doesn't stop commit on warnings #79

kiriDevs opened this issue Sep 1, 2022 · 0 comments
Labels
ci/cd/release Pull requests and issues regarding CI, CD or release mechanisms meta Things related to the repo, but not the codebase.

Comments

@kiriDevs
Copy link
Owner

kiriDevs commented Sep 1, 2022

The ESLint pre-commit hook doesn't stop a commit when a warning is thrown. I'd assume that also means the CI workflow still goes through, so we should make an extra script where ESLint actually exits with a non-zero code on warnings.
@kiriDevs kiriDevs added ci/cd/release Pull requests and issues regarding CI, CD or release mechanisms meta Things related to the repo, but not the codebase. labels Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ci/cd/release Pull requests and issues regarding CI, CD or release mechanisms meta Things related to the repo, but not the codebase.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kiriDevs