Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operationalize this repo #15

Closed
kingdonb opened this issue Aug 16, 2023 · 4 comments · Fixed by #13
Closed

Operationalize this repo #15

kingdonb opened this issue Aug 16, 2023 · 4 comments · Fixed by #13

Comments

@kingdonb
Copy link
Owner

There is a README for the link checker here, it has not published any releases yet:
https://github.com/kingdonb/link-checker-gpt#link-checker-gpt

An example use is configured as an internal test here - https://github.com/kingdonb/link-checker-gpt/blob/main/.github/workflows/pull-request.yml we can look at this in a separate issue for inclusion in the website CI, it will tell us when we're regressing in a PR. (I don't have another Netlify site that I can test it with, but it runs with a fixed PR number)

We need to test it on a Netlify site, (or we could build an adapter for something else to approximate the Netlify site... hint hint)

@kingdonb
Copy link
Owner Author

To publish this as a release, we should be building into a container image. That way we can avoid pulling the ruby runtime and gems into the workspace at runtime, and just launch the workflow instantly.

@kingdonb
Copy link
Owner Author

The logging has been cleaned up in #13 and we can see it works reliably now.

All that remains is to convert this into a so-called "reusable workflow"

https://github.com/orgs/community/discussions/36861

In this transition, we will have to curb our use of external workflows. This means the upload-artifact workflow goes away, and all output will be easier for users to observe directly in the report.

There is no need for a CSV output when the report is properly implemented. We can provide the output clear enough in the workflow logs, if they don't want to use upload-artifact. I am not sure how we can go on providing upload-artifact in the reusable workflow, but it is not a requirement and anyway this change will help to resolve:

@kingdonb
Copy link
Owner Author

The v1-beta branch is failing because of:

It is otherwise successful here though,

🎉

Little bit more work to do before we can call this a taggable release

@kingdonb
Copy link
Owner Author

Fixed #10 via v1-beta

#18 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant