Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning about ignoring workspace dependencies should not display when also upgrading workspace dependencies #898

Open
joshtriplett opened this issue Jun 24, 2024 · 1 comment

Comments

@joshtriplett
Copy link
Contributor

When upgrading an entire workspace, cargo upgrade first shows Checking virtual workspace's dependencies and goes through those, and then goes through the crates in the workspace. When doing the latter, in verbose mode (which is necessary to see the list of crates that need upgrading) it'll print a warning like warning: ignoring cratename, source is workspace for every workspace dependency.

This warning would be useful if cargo upgrade was only running on a single package in the workspace, to explain why it doesn't upgrade workspace dependencies. However, in the case where cargo upgrade is already looking at workspace dependencies in the same run, it seems unnecessary.

Suggestion: remember if cargo upgrade looked at workspace dependencies before, and if so:

  • Skip printing this warning
  • When printing "Checking cratename's dependencies", add "non-workspace" to that line
@epage
Copy link
Collaborator

epage commented Jun 25, 2024

Hadn't given the verbose output too much attention. Those messages should likely be switched to log messages.

I also haven't been giving cargo upgrade too much attention, instead encouraging effort towards cargo update --breaking which is now available in nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants