-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-upgrade feedback #830
Comments
crate roots 0.0.7 is installed, 0.0.8 is available Running this
updates Interestingly output contains both
and
^ there's multiple versions of When doing semver incompatible changes I would expect to update only them or things that are strictly required. When there's multiple versions of crates both being updated and not updated - it should be more explicit about what was updated and what wasn't. |
Yes, I have been considering pulling out the recursive flag and making that based on whether compatible upgrades are being done. |
Looking at this further, I think this needs to be split into separate issues. As a hint, if you can't give a specific title, than it likely is including too many things (like with commit messages). Having multiple things in one issue makes it harder to track the conversation and work and puts an extra burden on me as the maintainer. Without being split, the cost of these issues ends up being greater than they are worth and I tend to close them. |
#849 reduced the amount of space the summaries at the end take up. |
When running in a workspace with
parse-display 0.7.0
andparse-display 0.8.0
availableRunning this
outputs this:
Excluded list contains a bit more info than is useful - a list of all the crates it didn't updated, including workspace members which it can't possibly update.
This also does nothing to
parse-display
. Incompatible version is mentioned several times but unless you scroll up through several pages of output - it's impossible to see.When I ask to upgrade a specific crate - I would expect more info about what happened to it. Upgraded, not upgraded, etc.
Running this
Produces similar output, nothing is done to parse-display, no explanation why. It's the same version as currently in use, I would expect to see something like "nothing to do about parse-display" and less about ignored stuff I didn't ask to update.
Running this
produces an error
but also updates
Cargo.toml
andCargo.lock
files.The error message seems confusing, same as "both aggressive and precise". If something fails - I would expect it to fail without changing anything.
Running this
produces this
(0.9.0 does not exist), but error message is strange - as an end user I'm not using offline mode.
The text was updated successfully, but these errors were encountered: