[Bugfix] Improve YouTube shorts detection for new YouTube pants (#618)

kieraneglin · web-flow · commit b62eb2bc6bb6 · 2025-02-20T15:49:09.000-08:00
* Update youtube shorts detection to support youtube pants

* Updates a test
diff --git a/lib/pinchflat/yt_dlp/media.ex b/lib/pinchflat/yt_dlp/media.ex
@@ -151,7 +151,7 @@ defmodule Pinchflat.YtDlp.Media do
       #
       # These don't fail if duration or aspect_ratio are missing
       # due to Elixir's comparison semantics
-      response["duration"] <= 60 && response["aspect_ratio"] <= 0.85
+      response["duration"] <= 180 && response["aspect_ratio"] <= 0.85
     end
   end
 
diff --git a/test/pinchflat/yt_dlp/media_test.exs b/test/pinchflat/yt_dlp/media_test.exs
@@ -269,7 +269,7 @@ defmodule Pinchflat.YtDlp.MediaTest do
       response = %{
         "original_url" => "https://www.youtube.com/watch?v=TiZPUDkDYbk",
         "aspect_ratio" => 0.5,
-        "duration" => 59,
+        "duration" => 150,
         "upload_date" => "20210101"
       }
 

Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ defmodule Pinchflat.YtDlp.Media do`
`151`	`151`	`#`
`152`	`152`	`# These don't fail if duration or aspect_ratio are missing`
`153`	`153`	`# due to Elixir's comparison semantics`
`154`		`- response["duration"] <= 60 && response["aspect_ratio"] <= 0.85`
	`154`	`+ response["duration"] <= 180 && response["aspect_ratio"] <= 0.85`
`155`	`155`	`end`
`156`	`156`	`end`
`157`	`157`
Original file line number	Diff line number	Diff line change
`@@ -269,7 +269,7 @@ defmodule Pinchflat.YtDlp.MediaTest do`
`269`	`269`	`response = %{`
`270`	`270`	`"original_url" => "https://www.youtube.com/watch?v=TiZPUDkDYbk",`
`271`	`271`	`"aspect_ratio" => 0.5,`
`272`		`- "duration" => 59,`
	`272`	`+ "duration" => 150,`
`273`	`273`	`"upload_date" => "20210101"`
`274`	`274`	`}`
`275`	`275`