Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace diverse uses of JSON Schema $id handling with utility functions #19

Open
julrich opened this issue Oct 17, 2023 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@julrich
Copy link
Member

julrich commented Oct 17, 2023

Stuff like this:

const componentPath = rootSchema.$id.split('/');
const componentType = path.basename(rootSchema.$id).split('.')[0];

return n.$id.replace(/#.*$/g, '');

export function getSchemaName(schemaId: string | undefined): string {
  return (schemaId && schemaId.split('/').pop()?.split('.').shift()) || '';
}

export function getSchemaModule(schemaId: string | undefined): string {
  return (schemaId && schemaId.split('/')[3]) || '';
}

Should all be handled by common JSON Schema $id helpers (like the last two).

@julrich julrich added the enhancement New feature or request label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant