s3 file adapter filename option issue

[suqian1988]

Steps to reproduce the behavior

in S3 file adapter,
add below code to have customized file name.
but the file name is still random created string

myFile: {
  type: Types.File,
  storage: storage,
  filename: function (item, file) {
    console.log('item.id='+ item._id);
    return encodeURI(item._id + item.name);
  },
},

Expected behavior

we can plugin our own filename

Actual behavior

the file name is random string.

[mhoffmeyerDC]

I had the same issue with keystone-storage-adapter-s3.

@GwonHyeok had a bugfix.

I forked and updated the README with the new option.

[sktt]

@mhoffmeyerDC this should already work.

see the response in the pr keystonejs/keystone-storage-adapter-s3#5
there's also an example in there.

the generateFilename can look in two different ways

• Synchronous: function (file, attempt) { return 'filename' }
• Asynchronous function (file, attempt, callback) { callback('filename')}

However, the s3-storage-adapter does currently only do one attempt. If the file exists already, it is overwritten.

[Noviny]

Thanks @sktt for answering this. Closing this as an issue. Happy to reopen it if you feel this needs changes.